Bug 204697 - [Web Animations] Forward-filling animations should not schedule updates while filling
Summary: [Web Animations] Forward-filling animations should not schedule updates while...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on: 204709
Blocks:
  Show dependency tree / graph
 
Reported: 2019-11-29 02:16 PST by Antoine Quint
Modified: 2019-11-30 10:55 PST (History)
6 users (show)

See Also:

Attachments
Patch (19.88 KB, patch)
2019-11-29 02:36 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (19.76 KB, patch)
2019-11-30 04:26 PST, Antoine Quint 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-11-29 02:16:07 PST 
[Web Animations] Forward-filling animations should not schedule updates while filling
Comment 1 Antoine Quint 2019-11-29 02:36:11 PST 
Created attachment 384493 [details]
Patch
Comment 2 Antoine Quint 2019-11-29 10:11:43 PST 
Committed r252944: <https://trac.webkit.org/changeset/252944>
Comment 3 Radar WebKit Bug Importer 2019-11-29 10:12:19 PST 
<rdar://problem/57534005>
Comment 4 Aakash Jain 2019-11-29 13:34:45 PST 
(In reply to Antoine Quint from comment #2)
> Committed r252944: <https://trac.webkit.org/changeset/252944>
This broke Windows build with the error: 
WebAnimation.cpp(1325): warning C4715: 'WebCore::WebAnimation::timeToNextTick': not all control paths return a value

e.g.: https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Build%29/builds/8702


This failure was also indicated by EWS.
Comment 5 WebKit Commit Bot 2019-11-29 13:50:58 PST 
Re-opened since this is blocked by bug 204709
Comment 6 Antoine Quint 2019-11-30 04:26:13 PST 
Created attachment 384540 [details]
Patch
Comment 7 Antoine Quint 2019-11-30 05:11:53 PST 
Windows bots looking good with the new patch, which just adds a return clause after the switch statement in WebAnimation::timeToNextTick(). Not sure why that was required, the switch statement has a return state for all possible cases.
Comment 8 Antoine Quint 2019-11-30 05:15:58 PST 
Committed r252957: <https://trac.webkit.org/changeset/252957>