Bug 204691 - Old EWS is showing 'Submit to old EWS' button on every patch
Summary: Old EWS is showing 'Submit to old EWS' button on every patch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-28 11:38 PST by Aakash Jain
Modified: 2019-11-28 12:14 PST (History)
4 users (show)

See Also:


Attachments
Screenshot (325.84 KB, image/png)
2019-11-28 11:38 PST, Aakash Jain
no flags Details
Patch (1.40 KB, patch)
2019-11-28 11:42 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-11-28 11:38:30 PST
Now that all the queues (except commit-queue) have been removed from old EWS, it is showing 'Submit to old EWS' on all the patches. See attached screenshot.
Comment 1 Aakash Jain 2019-11-28 11:38:59 PST
Created attachment 384469 [details]
Screenshot
Comment 2 Aakash Jain 2019-11-28 11:42:34 PST
Created attachment 384471 [details]
Patch
Comment 3 Aakash Jain 2019-11-28 11:44:37 PST
We should remove the button altogether since it doesn't serve any purpose anymore after removal of all the queues from old EWS. Only commit-queue is remaining on old EWS, which is not affected by 'Submit to old EWS' button.
Comment 4 Aakash Jain 2019-11-28 11:45:15 PST
Committed r252931: <https://trac.webkit.org/changeset/252931>
Comment 5 Radar WebKit Bug Importer 2019-11-28 11:46:20 PST
<rdar://problem/57522644>
Comment 6 Alexey Proskuryakov 2019-11-28 11:59:55 PST
We should also rename "Submit to new EWS".
Comment 7 Aakash Jain 2019-11-28 12:05:19 PST
(In reply to Alexey Proskuryakov from comment #6)
> We should also rename "Submit to new EWS".
Yup, I was just going to do that.
Comment 8 Aakash Jain 2019-11-28 12:14:00 PST
(In reply to Alexey Proskuryakov from comment #6)
> We should also rename "Submit to new EWS".
Done in Bug 204692.