Bug 204678 – Move soft update handling to network process

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Move soft update handling to network process

[youenn fablet]

Created attachment 384450 [details]
Patch

[youenn fablet]

Created attachment 384454 [details]
Patch

[youenn fablet]

Created attachment 384459 [details]
Patch

[youenn fablet]

Created attachment 384480 [details]
Patch

[youenn fablet]

Created attachment 384697 [details]
Patch

[Chris Dumez]

Comment on attachment 384697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384697&action=review

> Source/WebCore/workers/service/ServiceWorkerJobData.cpp:79
> +        return scopeURL == job.scopeURL

Some of these checks may need to be case insensitive.

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h:55
> +    ServiceWorkerSoftUpdateLoader(NetworkSession&, WebCore::ServiceWorkerJobData&&, bool shouldRefreshCache, WebCore::ResourceRequest&&, Handler&&);

This should probably not be public, as clients are expected to call start().

[youenn fablet]

(In reply to Chris Dumez from comment #6)
> Comment on attachment 384697 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384697&action=review
> 
> > Source/WebCore/workers/service/ServiceWorkerJobData.cpp:79
> > +        return scopeURL == job.scopeURL
> 
> Some of these checks may need to be case insensitive.

Both script and scope are URLs.

We do URL string comparison for job when matching registration.
'HTTP://example.org/I' will then have a different scope compared to 'HTTP://example.org/i'. This is consistent.
I believe we should do the same for scripts as well.

> > Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h:55
> > +    ServiceWorkerSoftUpdateLoader(NetworkSession&, WebCore::ServiceWorkerJobData&&, bool shouldRefreshCache, WebCore::ResourceRequest&&, Handler&&);
> 
> This should probably not be public, as clients are expected to call start().

OK

[youenn fablet]

Created attachment 384802 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 384802 [details]
Patch for landing

Clearing flags on attachment: 384802

Committed r253102: <https://trac.webkit.org/changeset/253102>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57622145>