Bug 204674 - [GStreamer] Convert GLVideoSink and WebKitWebSrc to WEBKIT_DEFINE_TYPE
Summary: [GStreamer] Convert GLVideoSink and WebKitWebSrc to WEBKIT_DEFINE_TYPE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-28 03:11 PST by Philippe Normand
Modified: 2019-11-28 04:57 PST (History)
12 users (show)

See Also:

Attachments
Patch (8.85 KB, patch)
2019-11-28 03:35 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (8.98 KB, patch)
2019-11-28 03:52 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2019-11-28 03:11:37 PST 
.
Comment 1 Philippe Normand 2019-11-28 03:35:58 PST 
Created attachment 384446 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-11-28 03:51:27 PST 
Comment on attachment 384446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384446&action=review

> Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:78
> +    GST_DEBUG_CATEGORY_INIT(webkit_gl_video_sink_debug, "webkitglvideosink", 0, "GL video sink element"));

We don't need the ;

> Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:121
> +    GST_CALL_PARENT(G_OBJECT_CLASS, constructed, (object));

Do this at the beginning, in the case of constructed we want to construct the parent first.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:187
> +);

We don't need the ;

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:273
> +    GST_CALL_PARENT(G_OBJECT_CLASS, constructed, (object));

Same here, do this at the beginning.
Comment 3 Philippe Normand 2019-11-28 03:52:41 PST 
Created attachment 384447 [details]
Patch
Comment 4 Philippe Normand 2019-11-28 04:52:57 PST 
Committed r252918: <https://trac.webkit.org/changeset/252918>
Comment 5 Radar WebKit Bug Importer 2019-11-28 04:53:25 PST 
<rdar://problem/57519310>