Bug 204668 - Cache integer font metrics for performance
Summary: Cache integer font metrics for performance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-28 01:19 PST by Antti Koivisto
Modified: 2019-11-28 08:04 PST (History)
7 users (show)

See Also:


Attachments
patch (6.51 KB, patch)
2019-11-28 01:23 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-11-28 01:19:05 PST
Line layout uses integer metrics and queries them a lot. Avoid repeated rounding.
Comment 1 Antti Koivisto 2019-11-28 01:23:59 PST
Created attachment 384445 [details]
patch
Comment 2 zalan 2019-11-28 07:08:10 PST
Comment on attachment 384445 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384445&action=review

> Source/WebCore/ChangeLog:8
> +        Line layout uses integer metrics and queries them a lot. Avoid repeated rounding.

Eventually IFC (or any line layout system really) should call the float flavor and do proper snapping at the line level.
Comment 3 WebKit Commit Bot 2019-11-28 08:03:58 PST
Comment on attachment 384445 [details]
patch

Clearing flags on attachment: 384445

Committed r252927: <https://trac.webkit.org/changeset/252927>
Comment 4 WebKit Commit Bot 2019-11-28 08:04:00 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-11-28 08:04:28 PST
<rdar://problem/57521037>