RESOLVED FIXED 204668
Cache integer font metrics for performance 
https://bugs.webkit.org/show_bug.cgi?id=204668
Summary Cache integer font metrics for performance
Antti Koivisto
Reported 2019-11-28 01:19:05 PST
Line layout uses integer metrics and queries them a lot. Avoid repeated rounding.
Attachments
patch (6.51 KB, patch)
2019-11-28 01:23 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-11-28 01:23:59 PST
Created attachment 384445 [details] patch
zalan
Comment 2 2019-11-28 07:08:10 PST
Comment on attachment 384445 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=384445&action=review > Source/WebCore/ChangeLog:8 > + Line layout uses integer metrics and queries them a lot. Avoid repeated rounding. Eventually IFC (or any line layout system really) should call the float flavor and do proper snapping at the line level.
WebKit Commit Bot
Comment 3 2019-11-28 08:03:58 PST
Comment on attachment 384445 [details] patch Clearing flags on attachment: 384445 Committed r252927: <https://trac.webkit.org/changeset/252927>
WebKit Commit Bot
Comment 4 2019-11-28 08:04:00 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-11-28 08:04:28 PST
<rdar://problem/57521037>
Note You need to log in before you can comment on or make changes to this bug.