Bug 204666 - Remove ENABLE_KEYBOARD_CODE_ATTRIBUTE and ENABLE_KEYBOARD_KEY_ATTRIBUTE macros
Summary: Remove ENABLE_KEYBOARD_CODE_ATTRIBUTE and ENABLE_KEYBOARD_KEY_ATTRIBUTE macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-27 23:55 PST by Fujii Hironori
Modified: 2019-11-28 22:56 PST (History)
22 users (show)

See Also:

Attachments
Patch (74.40 KB, patch)
2019-11-28 00:01 PST, Fujii Hironori 		don.olmstead: review+
Details | Formatted Diff | Diff
Patch for landing (70.78 KB, patch)
2019-11-28 21:49 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-11-27 23:55:35 PST 
ENABLE_KEYBOARD_CODE_ATTRIBUTE and ENABLE_KEYBOARD_KEY_ATTRIBUTE macros are defined for all ports, remove them.
Comment 1 Fujii Hironori 2019-11-28 00:01:47 PST 
Created attachment 384439 [details]
Patch
Comment 2 Ross Kirsling 2019-11-28 20:41:31 PST 
Comment on attachment 384439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384439&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:289
> +ENABLE_MEDIA_STREAM_watchos = ENABLE_MEDIA_STREAM;
> +ENABLE_MEDIA_STREAM_watchsimulator = ENABLE_MEDIA_STREAM;
> +ENABLE_MEDIA_STREAM_appletvos = ENABLE_MEDIA_STREAM;
> +ENABLE_MEDIA_STREAM_appletvsimulator = ENABLE_MEDIA_STREAM;

Did you mean to add these four lines to each FeatureDefines.xcconfig?
Comment 3 Don Olmstead 2019-11-28 21:10:44 PST 
(In reply to Ross Kirsling from comment #2)
> Comment on attachment 384439 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384439&action=review
> 
> > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:289
> > +ENABLE_MEDIA_STREAM_watchos = ENABLE_MEDIA_STREAM;
> > +ENABLE_MEDIA_STREAM_watchsimulator = ENABLE_MEDIA_STREAM;
> > +ENABLE_MEDIA_STREAM_appletvos = ENABLE_MEDIA_STREAM;
> > +ENABLE_MEDIA_STREAM_appletvsimulator = ENABLE_MEDIA_STREAM;
> 
> Did you mean to add these four lines to each FeatureDefines.xcconfig?

The person who modified the base FeatureDefines.xcconfig is supposed to run a script to sync them. These lines are in the TestWebKitAPI one.
Comment 4 Fujii Hironori 2019-11-28 21:36:55 PST 
Yeah, I just ran sync-feature-defines script.
But, I shouldn't add those lines. They are removed in Bug 204254.
Very good catch! Thank you for saving me not to brake the watchOS and appleTV.
Comment 5 Fujii Hironori 2019-11-28 21:49:43 PST 
Created attachment 384479 [details]
Patch for landing
Comment 6 Fujii Hironori 2019-11-28 22:55:02 PST 
Comment on attachment 384479 [details]
Patch for landing

Clearing flags on attachment: 384479

Committed r252936: <https://trac.webkit.org/changeset/252936>
Comment 7 Fujii Hironori 2019-11-28 22:55:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-11-28 22:56:58 PST 
<rdar://problem/57527964>