When editing a string property, people may not add quotes. After trying the expression entered, the inspector should try again with quotes.
Created attachment 22902 [details] Proposed patch
Comment on attachment 22902 [details] Proposed patch + var result = WebInspector.panels.scripts.evaluateInSelectedCallFrame(expression, false); + else + var result = InspectorController.inspectedWindow().eval(expression); + return result; no need to store in a variable, just return in the two places. + var result = this.evaluateExpression("(" + expression + ")"); // Store the result in the property. this.parentObject[this.propertyName] = result; Put a empty line between the var result and the comment. + var result = this.evaluateExpression('"' + expression + '"'); + // Store the result in the property. + this.parentObject[this.propertyName] = result; You should escape double quotes in the expression, otherwise it will fail unexpectedly. Also put a empty line between the var result and the comment. r- for now until the string is escaped. Just do expression.escapeCharacters("\"");
Created attachment 22916 [details] Comments adressed
Landed in r35874.