Bug 204658 - [LFC][IFC] Re-introduce LineBuilder::isVisuallyNonEmpty function
Summary: [LFC][IFC] Re-introduce LineBuilder::isVisuallyNonEmpty function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-27 18:28 PST by zalan
Modified: 2019-11-28 06:44 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.78 KB, patch)
2019-11-27 18:34 PST, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-11-27 18:28:18 PST 
This function used to loop through the runs and bails out on the first non-empty run. This time it take the run as the parameter and check if it is visually empty or not.
Comment 1 Radar WebKit Bug Importer 2019-11-27 18:28:40 PST 
<rdar://problem/57512248>
Comment 2 zalan 2019-11-27 18:34:13 PST 
Created attachment 384430 [details]
Patch
Comment 3 zalan 2019-11-28 06:44:38 PST 
Committed r252923: <https://trac.webkit.org/changeset/252923>