Bug 204613 – [LFC][Render tree] Add LFC line layout path to RenderBlockFlow

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Antti Koivisto]

Basic line layout integration.

[Antti Koivisto]

Created attachment 384348 [details]
patch

[alan baradlay]

Comment on attachment 384348 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384348&action=review

> Source/WebCore/layout/RenderBlockFlowLineLayout.cpp:91
> +LayoutUnit RenderBlockFlowLineLayout::height() const

Since there are many different types of box height, I think it would be great if this function was named contentBoxHeight() (as opposed to padding/border/margin box height).

> Source/WebCore/layout/invalidation/InvalidationState.cpp:47
> +    if (layoutBox.isInitialContainingBlock()) {
> +        m_formattingContextRoots.add(downcast<Container>(layoutBox));
> +        return;
> +    }

As the comment/assert implies here the ICB should never need an update. It has to have a pre-computed geometry (in full LFC mode, it's always the view size, in partial LFC mode, I guess it's the flow's content box size). It's only the children that need update (layout).

[Antti Koivisto]

Created attachment 384368 [details]
patch

[WebKit Commit Bot]

Comment on attachment 384368 [details]
patch

Clearing flags on attachment: 384368

Committed r252893: <https://trac.webkit.org/changeset/252893>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57494369>

[Aakash Jain]

This broke loader/stateobjects/pushstate-size.html test on mac-debug. EWS did indicate this failure on previous version of patch. Tracked in Bug 204725.

[Antti Koivisto]

No(In reply to Aakash Jain from comment #7)
> This broke loader/stateobjects/pushstate-size.html test on mac-debug. EWS
> did indicate this failure on previous version of patch. Tracked in Bug
> 204725.

Very unlikely.

[Antti Koivisto]

> Very unlikely.

...but true. Adding enum value caused a bitfield to overflow (though the patch was otherwise no-op without enabling LFC).