Created attachment 384325 [details]
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Created attachment 384386 [details]
Fix test failures on Mac and iOS
(In reply to Alex Christensen from comment #4)
This broke the build for wincairo, as also indicated by EWS.
252989 failed in https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/13803
252988 passed in https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/13802
C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\ANGLE\Headers\GLES2\gl2ext_angle.h(641): fatal error C1083:
Cannot open include file: '../GLES3/gl32ext_explicit_context_autogen.inc': No such file or directory
Verified that it's not just a force clean issue:
Going to roll out.
Re-opened since this is blocked by bug 204767
Could someone with a WinCairo setup please figure out how to fix this? I don't have a setup to debug this, and uploading a 7+MB patch to EWS to iterate is not practical
I can fix it. Sorry, next time I will not request review until EWS passes. webkit-patch upload asks for review automatically, but I guess there is probably a flag to prevent that.
Oops, I forgot that rollouts don't auto-commit.
Looks like the fix is trivial so I'll commit that instead.
It often makes sense to review concurrently with waiting for EWS, but hopefully we can resolve all the detected issues before landing next time. :)
Committed r253012: <https://trac.webkit.org/changeset/253012>