Bug 204593 - Document::needsStyleRecalc() shouldn't return true for fragment scrolling (m_gotoAnchorNeededAfterStylesheetsLoad)
Summary: Document::needsStyleRecalc() shouldn't return true for fragment scrolling (m_...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari 12
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on: 203982
Blocks:
  Show dependency tree / graph
 
Reported: 2019-11-25 14:14 PST by Ryosuke Niwa
Modified: 2019-11-26 02:38 PST (History)
13 users (show)

See Also:

Attachments
Removes the code (1.61 KB, patch)
2019-11-25 14:17 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-11-25 14:14:14 PST 
After https://trac.webkit.org/r252761, fragment scrolling doesn't depend on style resolution.
Consequently, there is no need for Document::needsStyleRecalc() to return true
even when m_gotoAnchorNeededAfterStylesheetsLoad is set and there are no more pending stylesheets.
Comment 1 Ryosuke Niwa 2019-11-25 14:17:28 PST 
Created attachment 384317 [details]
Removes the code
Comment 2 Ryosuke Niwa 2019-11-26 01:53:09 PST 
Comment on attachment 384317 [details]
Removes the code

Nice! Let’s land this.
Comment 3 WebKit Commit Bot 2019-11-26 02:37:50 PST 
Comment on attachment 384317 [details]
Removes the code

Clearing flags on attachment: 384317

Committed r252881: <https://trac.webkit.org/changeset/252881>
Comment 4 WebKit Commit Bot 2019-11-26 02:37:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-11-26 02:38:21 PST 
<rdar://problem/57487005>