WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
204587
[bmalloc] Same variable name `sizeClassCount` is used differently in Heap.cpp
https://bugs.webkit.org/show_bug.cgi?id=204587
Summary
[bmalloc] Same variable name `sizeClassCount` is used differently in Heap.cpp
Basuke Suzuki
Reported
2019-11-25 10:25:13 PST
It is confusing.
Attachments
Add attachment
proposed patch, testcase, etc.
Basuke Suzuki
Comment 1
2019-11-25 13:39:26 PST
In Heap::initializeLineMetadata(), sizeClassCount is defined and initialized as bmalloc::sizeClass(smallLineSize). This variable is already defined in Sizes.h and used in different meaning. It is totally meaningful to rename variable name in initializeLineMetadata() from sizeClassCount to just classCount.
Basuke Suzuki
Comment 2
2020-01-16 14:17:14 PST
This name was changed while this patch landing.
https://bugs.webkit.org/show_bug.cgi?id=206044
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug