Bug 204584 - [LFC][IFC] Rename Line to LineBuilder
Summary: [LFC][IFC] Rename Line to LineBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-25 09:32 PST by zalan
Modified: 2019-11-25 10:34 PST (History)
6 users (show)

See Also:

Attachments
Patch (104.22 KB, patch)
2019-11-25 09:35 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-11-25 09:32:36 PST 
it really is a builder
Comment 1 Radar WebKit Bug Importer 2019-11-25 09:32:58 PST 
<rdar://problem/57474964>
Comment 2 zalan 2019-11-25 09:35:11 PST 
Created attachment 384302 [details]
Patch
Comment 3 Antti Koivisto 2019-11-25 09:40:52 PST 
Comment on attachment 384302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384302&action=review

> Source/WebCore/ChangeLog:3
> +        [LFC][IFC] Rename Line to LineBuilder

What an excellent name!

> Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:162
> +LineLayoutContext::IsEndOfLine LineLayoutContext::placeInlineItem(LineBuilder& line, const InlineItem& inlineItem)

Maybe the variables like this should be renamed too? Maybe in another patch...
Comment 4 zalan 2019-11-25 09:50:12 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 384302 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384302&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [LFC][IFC] Rename Line to LineBuilder
> 
> What an excellent name!
> 
> > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:162
> > +LineLayoutContext::IsEndOfLine LineLayoutContext::placeInlineItem(LineBuilder& line, const InlineItem& inlineItem)
> 
> Maybe the variables like this should be renamed too? Maybe in another
> patch...
Yeah, I was planning on doing it in a separate patch.
Comment 5 WebKit Commit Bot 2019-11-25 10:33:59 PST 
Comment on attachment 384302 [details]
Patch

Clearing flags on attachment: 384302

Committed r252865: <https://trac.webkit.org/changeset/252865>
Comment 6 WebKit Commit Bot 2019-11-25 10:34:01 PST 
All reviewed patches have been landed.  Closing bug.