RESOLVED FIXED204584
[LFC][IFC] Rename Line to LineBuilder 
https://bugs.webkit.org/show_bug.cgi?id=204584
Summary [LFC][IFC] Rename Line to LineBuilder
alan
Reported 2019-11-25 09:32:36 PST
it really is a builder
Attachments
Patch (104.22 KB, patch)
2019-11-25 09:35 PST, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-11-25 09:32:58 PST
<rdar://problem/57474964>
alan
Comment 2 2019-11-25 09:35:11 PST
Created attachment 384302 [details] Patch
Antti Koivisto
Comment 3 2019-11-25 09:40:52 PST
Comment on attachment 384302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384302&action=review > Source/WebCore/ChangeLog:3 > + [LFC][IFC] Rename Line to LineBuilder What an excellent name! > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:162 > +LineLayoutContext::IsEndOfLine LineLayoutContext::placeInlineItem(LineBuilder& line, const InlineItem& inlineItem) Maybe the variables like this should be renamed too? Maybe in another patch...
alan
Comment 4 2019-11-25 09:50:12 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 384302 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384302&action=review > > > Source/WebCore/ChangeLog:3 > > + [LFC][IFC] Rename Line to LineBuilder > > What an excellent name! > > > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:162 > > +LineLayoutContext::IsEndOfLine LineLayoutContext::placeInlineItem(LineBuilder& line, const InlineItem& inlineItem) > > Maybe the variables like this should be renamed too? Maybe in another > patch... Yeah, I was planning on doing it in a separate patch.
WebKit Commit Bot
Comment 5 2019-11-25 10:33:59 PST
Comment on attachment 384302 [details] Patch Clearing flags on attachment: 384302 Committed r252865: <https://trac.webkit.org/changeset/252865>
WebKit Commit Bot
Comment 6 2019-11-25 10:34:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.