Bug 204561 - [LFC][IFC] Construct only one LineLayout object per inline formatting context
Summary: [LFC][IFC] Construct only one LineLayout object per inline formatting context
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-24 18:57 PST by zalan
Modified: 2019-11-25 08:13 PST (History)
5 users (show)

See Also:


Attachments
Patch (17.50 KB, patch)
2019-11-24 19:14 PST, zalan
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-11-24 18:57:33 PST
and not one for each line.
Comment 1 Radar WebKit Bug Importer 2019-11-24 18:58:02 PST
<rdar://problem/57463666>
Comment 2 zalan 2019-11-24 19:14:33 PST
Created attachment 384263 [details]
Patch
Comment 3 Antti Koivisto 2019-11-25 07:13:06 PST
Comment on attachment 384263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384263&action=review

> Source/WebCore/ChangeLog:9
> +        Let's construct only one LineLayout object per IFC.

I kinda liked that one object represents layout of one line. What do we gain from reusing it?
Comment 4 zalan 2019-11-25 08:04:36 PST
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 384263 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384263&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Let's construct only one LineLayout object per IFC.
> 
> I kinda liked that one object represents layout of one line. What do we gain
> from reusing it?
What I am trying to achieve here is (and probably failing because of bad naming) to have something similar to what we do with the formatting contexts. In this setup the context is the LineLayout class. It is not a per-line-context but rather for the entire inline content. Let me find a better name for LineLayout and address it in a separate patch.
Comment 5 zalan 2019-11-25 08:05:48 PST
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 384263 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384263&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Let's construct only one LineLayout object per IFC.
> 
> I kinda liked that one object represents layout of one line. What do we gain
> from reusing it?
Line (or as we discussed the LineBuilder) class represents the layout of one line.
Comment 6 zalan 2019-11-25 08:13:24 PST
Committed r252861: <https://trac.webkit.org/changeset/252861>