Bug 204549 - Reduce JSC's binary size
Summary: Reduce JSC's binary size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-23 08:54 PST by Tadeu Zagallo
Modified: 2019-12-10 11:43 PST (History)
14 users (show)

See Also:

Attachments
Patch (51.74 KB, patch)
2019-11-23 09:07 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Patch (52.56 KB, patch)
2019-11-23 09:46 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Patch for landing (53.00 KB, patch)
2019-12-10 10:56 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2019-11-23 08:54:37 PST 
...
Comment 1 Tadeu Zagallo 2019-11-23 09:07:25 PST 
Created attachment 384238 [details]
Patch
Comment 2 Tadeu Zagallo 2019-11-23 09:46:13 PST 
Created attachment 384239 [details]
Patch

Fix build when WebAssembly is disabled
Comment 3 Saam Barati 2019-12-09 14:40:01 PST 
Comment on attachment 384239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384239&action=review

> Source/JavaScriptCore/ChangeLog:12
> +        - We were generating 2 instances of dumpBytecode, at 30kb each
> +        - We had 3 instances of computeUsesForBytecodeIndex at 11kb each
> +        - We had 8 instances of emit_compareAndJump(Slow) at 8kb (7kb for Slow) each.

you should say what you actually did. (e.g, made them one instance instead of N)
Comment 4 Tadeu Zagallo 2019-12-10 10:56:58 PST 
Created attachment 385286 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-12-10 11:41:47 PST 
Comment on attachment 385286 [details]
Patch for landing

Clearing flags on attachment: 385286

Committed r253335: <https://trac.webkit.org/changeset/253335>
Comment 6 WebKit Commit Bot 2019-12-10 11:41:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-12-10 11:43:22 PST 
<rdar://problem/57802078>