Bug 204532 – Web Inspector: Console: the saved result value is still shown after page reload

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE:
1. inspect any page
2. go to the Console Tab
3. enable Preserve Log
4. evaluate `{a: 1, b: 2, c: 3, d: 4, e: 5, f: 6, g: 7}`
 => notice the " == $1" next to it
5. reload the page
 => the " == $1" stays visible
6. repeat step 4
 => two " == $1" are shown

[Devin Rousso]

Created attachment 384188 [details]
Patch

[Blaze Burg]

Comment on attachment 384188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384188&action=review

> Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:248
> +        for (let node of this._messageBodyElement.querySelectorAll(".console-saved-variable"))

This seems fragile. Can we re-render() the messages in ConsoleMessageView and not draw the saved result index element if the message is older than the epoch (uh, probably since last page reload)?

[Devin Rousso]

Comment on attachment 384188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384188&action=review

>> Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:248
>> +        for (let node of this._messageBodyElement.querySelectorAll(".console-saved-variable"))
> 
> This seems fragile. Can we re-render() the messages in ConsoleMessageView and not draw the saved result index element if the message is older than the epoch (uh, probably since last page reload)?

Fragile in what way?  We don't ever save the `.console-saved-variable` element to a member variable, so it's basically "dropped" into the DOM with no expectations about it afterwards.

Re-rendering all of the messages would likely have pretty awful performance, especially if there are a lot of messages from previous sessions.

[Blaze Burg]

Comment on attachment 384188 [details]
Patch

r=me

I don't think it's worth making this any more complicated at this point.

[WebKit Commit Bot]

Comment on attachment 384188 [details]
Patch

Clearing flags on attachment: 384188

Committed r253000: <https://trac.webkit.org/changeset/253000>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57564556>