There is a request to make a failure to determine the upload configuration for the results database a soft failure, rather than a hard one.
Created attachment 384173 [details] Patch
Comment on attachment 384173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384173&action=review > Tools/Scripts/run-javascriptcore-tests:880 > + if (!keys $configuration) { is this tested?
Comment on attachment 384173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384173&action=review >> Tools/Scripts/run-javascriptcore-tests:880 >> + if (!keys $configuration) { > > is this tested? I did a test locally by modifying configurationForUpload() to return an empty hash, yes. 'key $configuration' will return a string, it will be an empty string if the hash is empty
Comment on attachment 384173 [details] Patch Clearing flags on attachment: 384173 Committed r252791: <https://trac.webkit.org/changeset/252791>
All reviewed patches have been landed. Closing bug.
<rdar://problem/57436631>
(In reply to Jonathan Bedard from comment #3) > >> + if (!keys $configuration) { > > is this tested? > > I did a test locally by modifying configurationForUpload() to return an > empty hash, yes. 'key $configuration' will return a string, it will be an > empty string if the hash is empty Seems like this broke the tests in different manner: https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/builds/10121/steps/jscore-test/logs/stdio It seems like this doesn't work with newer version of perl (or on the version of perl installed on the bots). Although it failed with different error on same bot here: https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/builds/10120/steps/jscore-test/logs/stdio
Reverted r252791 for reason: Cannot use key on scalar in some perl versions Committed r252797: <https://trac.webkit.org/changeset/252797>
Trying a different approach using uname.
Created attachment 384215 [details] Patch
Comment on attachment 384215 [details] Patch Clearing flags on attachment: 384215 Committed r252822: <https://trac.webkit.org/changeset/252822>