Media queries in img sizes attribute don't evaluate dynamically

[Antti Koivisto]

There is no code for evaluating on viewport etc changes.

[Antti Koivisto]

Created attachment 384160 [details]
patch

[Antti Koivisto]

Created attachment 384161 [details]
patch

[Simon Fraser (smfr)]

Comment on attachment 384161 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384161&action=review

> LayoutTests/fast/images/sizes-dynamic-001.html:5
> +<link rel="match" href="sizes-dynamic-001-ref.html">

Please fix this to point to the real ref file.

> LayoutTests/fast/images/sizes-dynamic-002.html:5
> +<link rel="match" href="sizes-dynamic-001-ref.html">

Ditto.

> Source/WebCore/dom/Document.h:1829
> +    HashSet<HTMLImageElement*> m_dynamicMediaQueryDependentImages;

Are we still using raw pointers for stuff like this?

[Antti Koivisto]

> Are we still using raw pointers for stuff like this?

We don't have WeakPtrs for Elements yet. But maybe I could add it for HTMLImageElement.

[Antti Koivisto]

> We don't have WeakPtrs for Elements yet. But maybe I could add it for
> HTMLImageElement.

I'm wrong, ContainerNodes are already CanMakeWeakPtr.

[Antti Koivisto]

Created attachment 384233 [details]
patch

[WebKit Commit Bot]

Comment on attachment 384233 [details]
patch

Clearing flags on attachment: 384233

Committed r252828: <https://trac.webkit.org/changeset/252828>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57451085>