Bug 204518 - run-webkit-tests: Failing to run spindump shouldn't be fatal
Summary: run-webkit-tests: Failing to run spindump shouldn't be fatal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-22 08:19 PST by Jonathan Bedard
Modified: 2019-11-22 09:51 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.44 KB, patch)
2019-11-22 08:39 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-11-22 08:19:24 PST
If spindump raises an exception, we sometimes abort the entire test run. This is a tremendous waste of machine time.
Comment 1 Jonathan Bedard 2019-11-22 08:19:49 PST
<rdar://problem/57397417>
Comment 2 Jonathan Bedard 2019-11-22 08:39:15 PST
Created attachment 384157 [details]
Patch
Comment 3 Aakash Jain 2019-11-22 08:58:56 PST
Comment on attachment 384157 [details]
Patch

where did you notice it?
Comment 4 Jonathan Bedard 2019-11-22 09:08:39 PST
(In reply to Aakash Jain from comment #3)
> Comment on attachment 384157 [details]
> Patch
> 
> where did you notice it?

Alexey noticed it on an Internal build. I didn't investigate too much, once I looked at the code and what the entire function does, it was transparently wrong, so I figured we should just fix it and move on.
Comment 5 WebKit Commit Bot 2019-11-22 09:51:38 PST
Comment on attachment 384157 [details]
Patch

Clearing flags on attachment: 384157

Committed r252779: <https://trac.webkit.org/changeset/252779>
Comment 6 WebKit Commit Bot 2019-11-22 09:51:43 PST
All reviewed patches have been landed.  Closing bug.