WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
204518
run-webkit-tests: Failing to run spindump shouldn't be fatal
https://bugs.webkit.org/show_bug.cgi?id=204518
Summary
run-webkit-tests: Failing to run spindump shouldn't be fatal
Jonathan Bedard
Reported
2019-11-22 08:19:24 PST
If spindump raises an exception, we sometimes abort the entire test run. This is a tremendous waste of machine time.
Attachments
Patch
(1.44 KB, patch)
2019-11-22 08:39 PST
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jonathan Bedard
Comment 1
2019-11-22 08:19:49 PST
<
rdar://problem/57397417
>
Jonathan Bedard
Comment 2
2019-11-22 08:39:15 PST
Created
attachment 384157
[details]
Patch
Aakash Jain
Comment 3
2019-11-22 08:58:56 PST
Comment on
attachment 384157
[details]
Patch where did you notice it?
Jonathan Bedard
Comment 4
2019-11-22 09:08:39 PST
(In reply to Aakash Jain from
comment #3
)
> Comment on
attachment 384157
[details]
> Patch > > where did you notice it?
Alexey noticed it on an Internal build. I didn't investigate too much, once I looked at the code and what the entire function does, it was transparently wrong, so I figured we should just fix it and move on.
WebKit Commit Bot
Comment 5
2019-11-22 09:51:38 PST
Comment on
attachment 384157
[details]
Patch Clearing flags on attachment: 384157 Committed
r252779
: <
https://trac.webkit.org/changeset/252779
>
WebKit Commit Bot
Comment 6
2019-11-22 09:51:43 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug