Bug 204517 – [ews] Add basic commit-queue support in new EWS

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Add basic commit-queue support in new EWS.

[Aakash Jain]

Created attachment 384155 [details]
Patch

[Aakash Jain]

Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/4

[Jonathan Bedard]

Comment on attachment 384155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384155&action=review

> Tools/BuildSlaveSupport/ews-build/config.json:517
> +      "workernames": ["webkit-cq-01", "webkit-cq-02", "webkit-cq-03"]

Are we actually intending to bring these online? Aren't these workers already functioning in the old commit queue?

> Tools/BuildSlaveSupport/ews-build/config.json:531
> +      "name": "try_commitqueue",

I'm a bit confused by what we're doing here.

[Aakash Jain]

(In reply to Jonathan Bedard from comment #3)
> Comment on attachment 384155 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384155&action=review
> 
> > Tools/BuildSlaveSupport/ews-build/config.json:517
> > +      "workernames": ["webkit-cq-01", "webkit-cq-02", "webkit-cq-03"]
> 
> Are we actually intending to bring these online? Aren't these workers already functioning in the old commit queue?
No today, we will move them when commit-queue is ready on new EWS. This is just part 1 for adding the support.
> 
> > Tools/BuildSlaveSupport/ews-build/config.json:531
> > +      "name": "try_commitqueue",
> 
> I'm a bit confused by what we're doing here.
We can't trigger commit-queue when we trigger all other queues. This would be triggered explicitly. EWS django app will run another 'buildbot try' command on this port for the patches with cq+ flag. It would be done in subsequent patch.

[Jonathan Bedard]

Comment on attachment 384155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384155&action=review

>>> Tools/BuildSlaveSupport/ews-build/config.json:531
>>> +      "name": "try_commitqueue",
>> 
>> I'm a bit confused by what we're doing here.
> 
> We can't trigger commit-queue when we trigger all other queues. This would be triggered explicitly. EWS django app will run another 'buildbot try' command on this port for the patches with cq+ flag. It would be done in subsequent patch.

So we basically, open up port 5557 and listen for a request to trigger commit queue?

[Aakash Jain]

(In reply to Jonathan Bedard from comment #5)
> So we basically, open up port 5557 and listen for a request to trigger commit queue?
Yes, just like we listen on 5555 to trigger rest of the queues.

[Aakash Jain]

Committed r252780: <https://trac.webkit.org/changeset/252780>

[Radar WebKit Bug Importer]

<rdar://problem/57432105>