Any empty list of list items can be discarded when parsing grid-template-rows, grid-template-columns, etc. This was discussed at: https://github.com/w3c/csswg-drafts/issues/4173 And this was fixed in Chromium in https://chromium-review.googlesource.com/c/chromium/src/+/1810454 This causes several failures in WPT tests under css/css-grid/parsing/
Created attachment 384313 [details] Patch
Comment on attachment 384313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384313&action=review > Source/WebCore/ChangeLog:15 > + Several WPT tets are passing thanks to this change. Typo: tets
Created attachment 384316 [details] Patch
Comment on attachment 384313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384313&action=review >> Source/WebCore/ChangeLog:15 >> + Several WPT tets are passing thanks to this change. > > Typo: tets Oops, thanks! Fixed that one and other typos on this ChangeLog.
View in context: https://bugs.webkit.org/attachment.cgi?id=384313&action=review >> Source/WebCore/ChangeLog:15 >> + Several WPT tets are passing thanks to this change. > > Typo: tets Oops, thanks! Fixed that one and other typos on this ChangeLog.
Comment on attachment 384316 [details] Patch After the patch for the tests import has landed this is ready for review. It's a small thing we haven't ported from Blink yet.
Comment on attachment 384316 [details] Patch Clearing flags on attachment: 384316 Committed r252883: <https://trac.webkit.org/changeset/252883>
All reviewed patches have been landed. Closing bug.
<rdar://problem/57488378>