Bug 204501 - [css-grid] Avoid serializing [] in grid-template* specified values
Summary: [css-grid] Avoid serializing [] in grid-template* specified values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords: BlinkMergeCandidate, InRadar
Depends on: 204585
Blocks:
  Show dependency treegraph
 
Reported: 2019-11-22 03:26 PST by Manuel Rego Casasnovas
Modified: 2019-11-26 04:10 PST (History)
10 users (show)

See Also:


Attachments
Patch (19.71 KB, patch)
2019-11-25 13:12 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch (19.71 KB, patch)
2019-11-25 13:53 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2019-11-22 03:26:09 PST
Any empty list of list items can be discarded when parsing grid-template-rows, grid-template-columns, etc.

This was discussed at: https://github.com/w3c/csswg-drafts/issues/4173

And this was fixed in Chromium in https://chromium-review.googlesource.com/c/chromium/src/+/1810454

This causes several failures in WPT tests under css/css-grid/parsing/
Comment 1 Manuel Rego Casasnovas 2019-11-25 13:12:18 PST
Created attachment 384313 [details]
Patch
Comment 2 Oriol Brufau 2019-11-25 13:43:21 PST
Comment on attachment 384313 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384313&action=review

> Source/WebCore/ChangeLog:15
> +        Several WPT tets are passing thanks to this change.

Typo: tets
Comment 3 Manuel Rego Casasnovas 2019-11-25 13:53:21 PST
Created attachment 384316 [details]
Patch
Comment 4 Manuel Rego Casasnovas 2019-11-25 13:53:43 PST
Comment on attachment 384313 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384313&action=review

>> Source/WebCore/ChangeLog:15
>> +        Several WPT tets are passing thanks to this change.
> 
> Typo: tets

Oops, thanks! Fixed that one and other typos on this ChangeLog.
Comment 5 Manuel Rego Casasnovas 2019-11-25 13:53:51 PST
View in context: https://bugs.webkit.org/attachment.cgi?id=384313&action=review

>> Source/WebCore/ChangeLog:15
>> +        Several WPT tets are passing thanks to this change.
> 
> Typo: tets

Oops, thanks! Fixed that one and other typos on this ChangeLog.
Comment 6 Manuel Rego Casasnovas 2019-11-25 23:15:10 PST
Comment on attachment 384316 [details]
Patch

After the patch for the tests import has landed this is ready for review.
It's a small thing we haven't ported from Blink yet.
Comment 7 WebKit Commit Bot 2019-11-26 04:09:11 PST
Comment on attachment 384316 [details]
Patch

Clearing flags on attachment: 384316

Committed r252883: <https://trac.webkit.org/changeset/252883>
Comment 8 WebKit Commit Bot 2019-11-26 04:09:13 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-11-26 04:10:21 PST
<rdar://problem/57488378>