Bug 204499 - Use SWClientConnection instead of hopping to main thread in ServiceWorkerContainer
Summary: Use SWClientConnection instead of hopping to main thread in ServiceWorkerCont...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-22 02:21 PST by youenn fablet
Modified: 2019-11-25 01:14 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.59 KB, patch)
2019-11-22 02:23 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (3.59 KB, patch)
2019-11-22 02:26 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (7.30 KB, patch)
2019-11-22 10:40 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-11-22 02:21:47 PST 
Use SWClientConnection instead of hopping to main thread in ServiceWorkerContainer
Comment 1 youenn fablet 2019-11-22 02:23:46 PST 
Created attachment 384136 [details]
Patch
Comment 2 youenn fablet 2019-11-22 02:26:54 PST 
Created attachment 384137 [details]
Patch
Comment 3 Chris Dumez 2019-11-22 08:11:49 PST 
Comment on attachment 384137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384137&action=review

> Source/WebCore/workers/service/ServiceWorkerContainer.cpp:502
> +    ensureSWClientConnection().failedFetchingScript(job.identifier(), job.data().registrationKey(), error);

SWClientConnection::failedFetchingScript() seems to ASSERT(isMainThread());
Comment 4 youenn fablet 2019-11-22 10:40:14 PST 
Created attachment 384168 [details]
Patch
Comment 5 WebKit Commit Bot 2019-11-25 01:13:48 PST 
Comment on attachment 384168 [details]
Patch

Clearing flags on attachment: 384168

Committed r252848: <https://trac.webkit.org/changeset/252848>
Comment 6 WebKit Commit Bot 2019-11-25 01:13:50 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-11-25 01:14:28 PST 
<rdar://problem/57467919>