RESOLVED FIXED 204499
Use SWClientConnection instead of hopping to main thread in ServiceWorkerContainer 
https://bugs.webkit.org/show_bug.cgi?id=204499
Summary Use SWClientConnection instead of hopping to main thread in ServiceWorkerCont...
youenn fablet
Reported 2019-11-22 02:21:47 PST
Use SWClientConnection instead of hopping to main thread in ServiceWorkerContainer
Attachments
Patch (3.59 KB, patch)
2019-11-22 02:23 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (3.59 KB, patch)
2019-11-22 02:26 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (7.30 KB, patch)
2019-11-22 10:40 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-11-22 02:23:46 PST
Created attachment 384136 [details] Patch
youenn fablet
Comment 2 2019-11-22 02:26:54 PST
Created attachment 384137 [details] Patch
Chris Dumez
Comment 3 2019-11-22 08:11:49 PST
Comment on attachment 384137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384137&action=review > Source/WebCore/workers/service/ServiceWorkerContainer.cpp:502 > + ensureSWClientConnection().failedFetchingScript(job.identifier(), job.data().registrationKey(), error); SWClientConnection::failedFetchingScript() seems to ASSERT(isMainThread());
youenn fablet
Comment 4 2019-11-22 10:40:14 PST
Created attachment 384168 [details] Patch
WebKit Commit Bot
Comment 5 2019-11-25 01:13:48 PST
Comment on attachment 384168 [details] Patch Clearing flags on attachment: 384168 Committed r252848: <https://trac.webkit.org/changeset/252848>
WebKit Commit Bot
Comment 6 2019-11-25 01:13:50 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-11-25 01:14:28 PST
<rdar://problem/57467919>
Note You need to log in before you can comment on or make changes to this bug.