Bug 204495 - Support JSCOnly platform in test reporting
Summary: Support JSCOnly platform in test reporting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Paulo Matos
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-22 01:26 PST by Paulo Matos
Modified: 2019-11-22 06:56 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.40 KB, patch)
2019-11-22 02:33 PST, Paulo Matos
no flags Details | Formatted Diff | Diff
Patch (1.39 KB, patch)
2019-11-22 03:40 PST, Paulo Matos
no flags Details | Formatted Diff | Diff
Patch (1.39 KB, patch)
2019-11-22 06:08 PST, Paulo Matos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paulo Matos 2019-11-22 01:26:41 PST
Build for 32bit jsconly worker is failing since 204091 made it upstream.

--report is used which causes configurationForUpload to be called but it fails without determining platform.
See https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/builds/10060/steps/jscore-test/logs/stdio
Comment 1 Paulo Matos 2019-11-22 02:33:17 PST
Created attachment 384138 [details]
Patch
Comment 2 Paulo Matos 2019-11-22 03:40:05 PST
Created attachment 384140 [details]
Patch
Comment 3 Carlos Garcia Campos 2019-11-22 04:59:12 PST
Comment on attachment 384140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384140&action=review

> Tools/Scripts/run-javascriptcore-tests:395
> +            chomp($version = `/usr/bin/uname -r`);

Use just uname, that should be in PATH, see bug #204452
Comment 4 Paulo Matos 2019-11-22 06:08:57 PST
Created attachment 384146 [details]
Patch
Comment 5 Paulo Matos 2019-11-22 06:09:30 PST
(In reply to Carlos Garcia Campos from comment #3)
> Comment on attachment 384140 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384140&action=review
> 
> > Tools/Scripts/run-javascriptcore-tests:395
> > +            chomp($version = `/usr/bin/uname -r`);
> 
> Use just uname, that should be in PATH, see bug #204452

Thanks for the review. Fixed in latest patch.
Comment 6 WebKit Commit Bot 2019-11-22 06:55:10 PST
Comment on attachment 384146 [details]
Patch

Clearing flags on attachment: 384146

Committed r252773: <https://trac.webkit.org/changeset/252773>
Comment 7 WebKit Commit Bot 2019-11-22 06:55:12 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-11-22 06:56:20 PST
<rdar://problem/57427984>