RESOLVED FIXED 204494
replaceUsingStringSearch() should not use CachedCall with host functions. 
https://bugs.webkit.org/show_bug.cgi?id=204494
Summary replaceUsingStringSearch() should not use CachedCall with host functions.
Mark Lam
Reported 2019-11-21 23:48:26 PST
<rdar://problem/57421078>
Attachments
proposed patch. (3.64 KB, patch)
2019-11-21 23:54 PST, Mark Lam 		ross.kirsling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-11-21 23:54:02 PST
Created attachment 384128 [details] proposed patch.
Ross Kirsling
Comment 2 2019-11-22 00:39:27 PST
Comment on attachment 384128 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=384128&action=review > Source/JavaScriptCore/runtime/StringPrototype.cpp:812 > - if (cachedCall) { > + if (callType == CallType::JS) { Might be clearer to leave this line -- then the branch reads as "if we have a cached call then call it".
Mark Lam
Comment 3 2019-11-22 01:34:09 PST
Comment on attachment 384128 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=384128&action=review Thanks for the review. >> Source/JavaScriptCore/runtime/StringPrototype.cpp:812 >> + if (callType == CallType::JS) { > > Might be clearer to leave this line -- then the branch reads as "if we have a cached call then call it". Good point. I'll change it.
Mark Lam
Comment 4 2019-11-22 01:40:09 PST
Landed in r252766: <http://trac.webkit.org/r252766>.
Note You need to log in before you can comment on or make changes to this bug.