Bug 204491 - Associate each microtask with a task group and remove ActiveDOMCallbackMicrotask
Summary: Associate each microtask with a task group and remove ActiveDOMCallbackMicrotask
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 204042
  Show dependency tree / graph
 
Reported: 2019-11-21 22:32 PST by Ryosuke Niwa
Modified: 2019-11-22 17:53 PST (History)
12 users (show)

See Also:

Attachments
Cleanup (23.89 KB, patch)
2019-11-21 22:44 PST, Ryosuke Niwa 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-11-21 22:32:52 PST 
We should associate each microtask with a EventLoopTaskGroup like we do with a regular task.
This will allow suspension & stopping of each microtask when the task group's script execution context is suspend or stopped,
and eliminates the need for ActiveDOMCallbackMicrotask.
Comment 1 Ryosuke Niwa 2019-11-21 22:44:16 PST 
Created attachment 384125 [details]
Cleanup
Comment 2 Radar WebKit Bug Importer 2019-11-21 22:45:15 PST 
<rdar://problem/57420554>
Comment 3 Ryosuke Niwa 2019-11-22 10:12:10 PST 
Ping reviewers.
Comment 4 Antti Koivisto 2019-11-22 11:31:07 PST 
Comment on attachment 384125 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=384125&action=review

nice!

> Source/WebCore/ChangeLog:12
> +        suspsned or stopped along with the script execution context without having to wrap each

typo suspended
Comment 5 Ryosuke Niwa 2019-11-22 17:53:21 PST 
Committed r252820: <https://trac.webkit.org/changeset/252820>