[Cocoa] Rename some internal names for system fonts

[Myles C. Maxfield]

[Cocoa] Rename some internal names for system fonts

[Myles C. Maxfield]

Created attachment 384120 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 384120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384120&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1272
> +    Optional<SystemFontDatabaseCoreText::Purpose> systemDesign;

I think SystemFontDatabaseCoreText::Purpose could have a much better name if it wasn't hobbled by the enum being inside the SystemFontDatabaseCoreText class. The fact it's a database doesn't seem relevant here.

[EWS Watchlist]

Comment on attachment 384120 [details]
Patch

Attachment 384120 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13272748

New failing tests:
fast/workers/worker-cloneport.html

[EWS Watchlist]

Created attachment 384143 [details]
Archive of layout-test-results from ews214 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Myles C. Maxfield]

Created attachment 384187 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 384187 [details]
Patch

So much better!

[WebKit Commit Bot]

Comment on attachment 384187 [details]
Patch

Clearing flags on attachment: 384187

Committed r252806: <https://trac.webkit.org/changeset/252806>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57441628>