Bug 204473 - Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'target.PageAgent.getCompositingBordersVisible')
Summary: Web Inspector: Uncaught Exception: TypeError: undefined is not an object (eva...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-21 14:03 PST by Devin Rousso
Modified: 2019-11-22 16:15 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.36 KB, patch)
2019-11-21 14:22 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-11-21 14:03:02 PST 
Uncaught Exception in Web Inspector.

Steps to Reproduce:
1. inspect any page
2. go to the Layers Tab
3. close Web Inspector
4. open Web Inspector

Uncaught Exceptions:
-----------------------
 - TypeError: undefined is not an object (evaluating 'target.PageAgent.getCompositingBordersVisible') (at Layers3DContentView.js:426:25)
    _updateCompositingBordersButtonState @ Layers3DContentView.js:426:25
    shown @ Layers3DContentView.js:83:50
    prepareToShow @ BackForwardEntry.js:84:35
    _showEntry @ ContentViewContainer.js:456:28
    showBackForwardEntryForIndex @ ContentViewContainer.js:166:28
    showContentView @ ContentViewContainer.js:142:42
    shown @ LayersTabContentView.js:73:44
    prepareToShow @ BackForwardEntry.js:84:35
    _showEntry @ ContentViewContainer.js:456:28
    showBackForwardEntryForIndex @ ContentViewContainer.js:166:28
    showContentView @ ContentViewContainer.js:142:42
    _tabBarItemSelected @ TabBrowser.js:240:55
    dispatch @ Object.js:165:30
    dispatchEventToListeners @ Object.js:172:17
    selectedTabBarItem @ LegacyTabBar.js:387:38
    ? @ Main.js:510:14
-----------------------

Notes:
Inspected URL:        (unknown)
Loading completed:    false
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko)
Comment 1 Devin Rousso 2019-11-21 14:22:10 PST 
Created attachment 384090 [details]
Patch
Comment 2 BJ Burg 2019-11-22 14:37:03 PST 
Comment on attachment 384090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384090&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/TargetManager.js:261
> +        WI._backendTargetAvailablePromise.resolve();

This reads nice now.

> Source/WebInspectorUI/UserInterface/Controllers/TargetManager.js:273
> +        WI._pageTargetAvailablePromise.resolve();

Ditto :)
Comment 3 WebKit Commit Bot 2019-11-22 16:14:56 PST 
Comment on attachment 384090 [details]
Patch

Clearing flags on attachment: 384090

Committed r252814: <https://trac.webkit.org/changeset/252814>
Comment 4 WebKit Commit Bot 2019-11-22 16:14:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-11-22 16:15:37 PST 
<rdar://problem/57444627>