Bug 204466 - [LFC][IFC] Cache trailing trimmable width.
Summary: [LFC][IFC] Cache trailing trimmable width.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-21 12:31 PST by zalan
Modified: 2019-11-21 13:42 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.59 KB, patch)
2019-11-21 12:40 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-11-21 12:31:25 PST 
We shouldn't really need to loop through the trailing trimmable runs.
Comment 1 Radar WebKit Bug Importer 2019-11-21 12:31:35 PST 
<rdar://problem/57403888>
Comment 2 zalan 2019-11-21 12:40:15 PST 
Created attachment 384082 [details]
Patch
Comment 3 Antti Koivisto 2019-11-21 12:46:01 PST 
Comment on attachment 384082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384082&action=review

> Source/WebCore/layout/inlineformatting/InlineLine.h:160
> +        using TrimmableList = Vector<InlineItemRun*, 5>;

Do we need this many?
Comment 4 WebKit Commit Bot 2019-11-21 13:42:49 PST 
Comment on attachment 384082 [details]
Patch

Clearing flags on attachment: 384082

Committed r252750: <https://trac.webkit.org/changeset/252750>
Comment 5 WebKit Commit Bot 2019-11-21 13:42:51 PST 
All reviewed patches have been landed.  Closing bug.