Bug 204464 - Remove unneeded code that annotated DOMHTMLElement as conforming to UITextInputTraits protocol
Summary: Remove unneeded code that annotated DOMHTMLElement as conforming to UITextInp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 13
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-21 12:03 PST by Daniel Bates
Modified: 2019-11-21 12:28 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2019-11-21 12:13 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-11-21 12:03:38 PST 
Following the fix for bug #177917, DOMHTMLElement no longer needs to be annotated as conforming to UITextInputTraits protocol. It never really did implement that protocol. When it was annotated as implementing the UITextInputTraits protocol it was only to register with the runtime so that callers could send -acceptsAutofilledLoginCredentials and -representingPageURL messages to it. And those functions were removed in the patch for bug bug #177917.
Comment 1 Daniel Bates 2019-11-21 12:04:28 PST 
FYI, patch for bug #174394 first annotated DOMHTMLElement as implementing the UITextInputTraits protocol
Comment 2 Daniel Bates 2019-11-21 12:13:14 PST 
Created attachment 384080 [details]
Patch
Comment 3 Daniel Bates 2019-11-21 12:27:52 PST 
Comment on attachment 384080 [details]
Patch

Clearing flags on attachment: 384080

Committed r252746: <https://trac.webkit.org/changeset/252746>
Comment 4 Daniel Bates 2019-11-21 12:27:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-11-21 12:28:21 PST 
<rdar://problem/57403788>