Bug 20446 - rename NPCocoaEvent's "event" struct to "data"
Summary: rename NPCocoaEvent's "event" struct to "data"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Josh Aas
URL: https://wiki.mozilla.org/Mac:NPAPI_Ev...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2008-08-19 11:21 PDT by Josh Aas
Modified: 2008-08-20 14:04 PDT (History)
1 user (show)

See Also:


Attachments
fix v1.0 (6.81 KB, patch)
2008-08-19 11:26 PDT, Josh Aas
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Aas 2008-08-19 11:21:29 PDT
We should rename NPCocoaEvent's "event" structure to "data" to avoid things like "event->event.draw.x" and "event.event.draw.x". People tend to name the NPCocoaEvent "event" and it doesn't read well. This happens often in WebKit's impl and it'll happen all over plugin code written for the Cocoa event model.

We'd change the spec here:

https://wiki.mozilla.org/Mac:NPAPI_Event_Models
Comment 1 Josh Aas 2008-08-19 11:26:02 PDT
Created attachment 22878 [details]
fix v1.0
Comment 2 Anders Carlsson 2008-08-19 11:30:18 PDT
Comment on attachment 22878 [details]
fix v1.0

r=me
Comment 3 Anders Carlsson 2008-08-20 13:57:48 PDT
<rdar://problem/6163636>
Comment 4 Anders Carlsson 2008-08-20 14:04:39 PDT
Committed revision 35861.