Bug 204435 - GetByStatus should not say it took the slow path for multiple identifiers and should have a way to indicate if the StructureStubInfo it saw took the slow path
Summary: GetByStatus should not say it took the slow path for multiple identifiers and...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-20 17:54 PST by Saam Barati
Modified: 2019-11-21 21:43 PST (History)
14 users (show)

See Also:

Attachments
patch (34.33 KB, patch)
2019-11-21 15:31 PST, Saam Barati 		tzagallo: review+
Details | Formatted Diff | Diff
patch for landing (44.49 KB, patch)
2019-11-21 17:52 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing (44.51 KB, patch)
2019-11-21 17:55 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-11-20 17:54:22 PST 
I forgot to upload my microbenchmarks in the actual patch.
Comment 1 Saam Barati 2019-11-21 15:31:25 PST 
Created attachment 384097 [details]
patch
Comment 2 Tadeu Zagallo 2019-11-21 15:44:46 PST 
Comment on attachment 384097 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384097&action=review

r=me.

> Source/JavaScriptCore/ChangeLog:24
> +        between a GetByStatus saying "we're a slow path" and if we actually observed the StructureStubInfo
> +        go to the slow path. In the DFG/FTL, we only forgo emitting a get by val IC when observing a

Maybe it's just me, but I found this a bit confusing throughout the patch. It's kinda weird that we say it's a slow path if the slow path wasn't taken, but I'm not sure what would be a better alternative, so I'll leave it to you to decide whether it makes sense or not.
Comment 3 Saam Barati 2019-11-21 17:52:05 PST 
Created attachment 384111 [details]
patch for landing
Comment 4 Saam Barati 2019-11-21 17:55:48 PST 
Created attachment 384113 [details]
patch for landing
Comment 5 WebKit Commit Bot 2019-11-21 21:42:04 PST 
Comment on attachment 384113 [details]
patch for landing

Clearing flags on attachment: 384113

Committed r252763: <https://trac.webkit.org/changeset/252763>
Comment 6 WebKit Commit Bot 2019-11-21 21:42:05 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-11-21 21:43:21 PST 
<rdar://problem/57419422>