Bug 204434 – Crash at com.apple.WebCore: -[WebRevealHighlight revealContext:drawRectsForItem:]

• Status: RESOLVED
• Resolution: FIXED
• Component: PDF

[Conrad Shultz]

It's possible to trigger a crash under -[WebRevealHighlight revealContext:drawRectsForItem:].

[Conrad Shultz]

<rdar://problem/57123416>

[Conrad Shultz]

Created attachment 384016 [details]
Patch

[Megan Gardner]

Comment on attachment 384016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384016&action=review

r+ as long as you make sure that old systems aren't going to be broken.

> Source/WebCore/editing/cocoa/DictionaryLookup.mm:82
>  }

I know I did this on purpose, I believe so that it would work on older 32 bit systems, but we might not compile for them anymore. Please verify that this is true before removing.

> Source/WebCore/editing/cocoa/DictionaryLookup.mm:-101
> -

Ditto.

[Conrad Shultz]

(In reply to Megan Gardner from comment #3)
> Comment on attachment 384016 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384016&action=review
> 
> r+ as long as you make sure that old systems aren't going to be broken.
> 
> > Source/WebCore/editing/cocoa/DictionaryLookup.mm:82
> >  }
> 
> I know I did this on purpose, I believe so that it would work on older 32
> bit systems, but we might not compile for them anymore. Please verify that
> this is true before removing.
> 
> > Source/WebCore/editing/cocoa/DictionaryLookup.mm:-101
> > -
> 
> Ditto.

We should be good as of macOS Catalina. Bots are green too. Thanks!

[WebKit Commit Bot]

Comment on attachment 384016 [details]
Patch

Clearing flags on attachment: 384016

Committed r252729: <https://trac.webkit.org/changeset/252729>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.