Bug 204432 - Baseline JIT should fill in StructureStubInfo's propertyIsInt32 and the slow path should update the array profile more frequently
Summary: Baseline JIT should fill in StructureStubInfo's propertyIsInt32 and the slow ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-20 17:37 PST by Saam Barati
Modified: 2019-11-20 18:01 PST (History)
13 users (show)

See Also:

Attachments
patch (3.59 KB, patch)
2019-11-20 17:47 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (3.59 KB, patch)
2019-11-20 17:49 PST, Saam Barati 		tzagallo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-11-20 17:37:31 PST 
...
Comment 1 Saam Barati 2019-11-20 17:47:50 PST 
Created attachment 384013 [details]
patch
Comment 2 Saam Barati 2019-11-20 17:48:42 PST 
Comment on attachment 384013 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384013&action=review

> Source/JavaScriptCore/jit/JITOperations.cpp:2013
> +        Structure* structure = baseValue.structureOrNull();

let me improve this to just call structure()
Comment 3 Saam Barati 2019-11-20 17:49:57 PST 
Created attachment 384014 [details]
patch
Comment 4 Tadeu Zagallo 2019-11-20 17:51:54 PST 
Comment on attachment 384014 [details]
patch

r=me
Comment 5 Saam Barati 2019-11-20 18:00:38 PST 
landed in:
https://trac.webkit.org/changeset/252725/webkit
Comment 6 Radar WebKit Bug Importer 2019-11-20 18:01:24 PST 
<rdar://problem/57380299>