Bug 204426 - run-webkit-tests: Do not create global SystemHost objects
Summary: run-webkit-tests: Do not create global SystemHost objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-20 15:37 PST by Jonathan Bedard
Modified: 2019-11-20 17:26 PST (History)
7 users (show)

See Also:


Attachments
Patch (5.74 KB, patch)
2019-11-20 15:41 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (5.77 KB, patch)
2019-11-20 17:04 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-11-20 15:37:55 PST
Stumbled upon this when fixing https://bugs.webkit.org/show_bug.cgi?id=204423.
Comment 1 Jonathan Bedard 2019-11-20 15:41:43 PST
Created attachment 383997 [details]
Patch
Comment 2 Aakash Jain 2019-11-20 16:48:10 PST
Comment on attachment 383997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383997&action=review

> Tools/Scripts/webkitpy/xcode/simulated_device.py:168
> +    def device_by_filter(filter, host=None):

missing 'host = host or SystemHost()' in this function?
Comment 3 Jonathan Bedard 2019-11-20 17:04:46 PST
Created attachment 384005 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-11-20 17:25:26 PST
Comment on attachment 384005 [details]
Patch for landing

Clearing flags on attachment: 384005

Committed r252722: <https://trac.webkit.org/changeset/252722>
Comment 5 WebKit Commit Bot 2019-11-20 17:25:27 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-11-20 17:26:20 PST
<rdar://problem/57379300>