RESOLVED FIXED 204426
run-webkit-tests: Do not create global SystemHost objects 
https://bugs.webkit.org/show_bug.cgi?id=204426
Summary run-webkit-tests: Do not create global SystemHost objects
Jonathan Bedard
Reported 2019-11-20 15:37:55 PST
Stumbled upon this when fixing https://bugs.webkit.org/show_bug.cgi?id=204423.
Attachments
Patch (5.74 KB, patch)
2019-11-20 15:41 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.77 KB, patch)
2019-11-20 17:04 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-11-20 15:41:43 PST
Created attachment 383997 [details] Patch
Aakash Jain
Comment 2 2019-11-20 16:48:10 PST
Comment on attachment 383997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383997&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:168 > + def device_by_filter(filter, host=None): missing 'host = host or SystemHost()' in this function?
Jonathan Bedard
Comment 3 2019-11-20 17:04:46 PST
Created attachment 384005 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-11-20 17:25:26 PST
Comment on attachment 384005 [details] Patch for landing Clearing flags on attachment: 384005 Committed r252722: <https://trac.webkit.org/changeset/252722>
WebKit Commit Bot
Comment 5 2019-11-20 17:25:27 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-11-20 17:26:20 PST
<rdar://problem/57379300>
Note You need to log in before you can comment on or make changes to this bug.