Bug 204424 - Web Inspector: call frames from blackboxed scripts should be visually distinct
Summary: Web Inspector: call frames from blackboxed scripts should be visually distinct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-20 15:09 PST by Devin Rousso
Modified: 2019-11-21 12:07 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.22 KB, patch)
2019-11-20 15:25 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (205.11 KB, image/png)
2019-11-20 15:25 PST, Devin Rousso 		no flags Details
Patch (10.88 KB, patch)
2019-11-21 11:19 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-11-20 15:09:46 PST 
Seeing "Deferred pause from blackboxed script" in the Pause Reason does clarify that something in the Call Stack was blackboxed, but it doesn't indicate what was blackboxed.  Given that the debugger effectively ignores blackboxed scripts, we should distinguish them as such in the UI.
Comment 1 Devin Rousso 2019-11-20 15:25:19 PST 
Created attachment 383992 [details]
Patch
Comment 2 Devin Rousso 2019-11-20 15:25:31 PST 
Created attachment 383993 [details]
[Image] After Patch is applied
Comment 3 Timothy Hatcher 2019-11-21 03:30:41 PST 
Comment on attachment 383992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383992&action=review

> Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.js:96
> +                tooltipSuffix += "\n\n" + WI.UIString("Script ignored when debugging");

This should mention black boxing as a reason why it was ignored.
Comment 4 Devin Rousso 2019-11-21 11:19:46 PST 
Created attachment 384076 [details]
Patch
Comment 5 Devin Rousso 2019-11-21 11:20:19 PST 
Comment on attachment 384076 [details]
Patch

I also updated the tooltip/contextmenu text for things related to blackboxing so they actually include the word "blackbox" (or something like it).
Comment 6 WebKit Commit Bot 2019-11-21 12:06:27 PST 
Comment on attachment 384076 [details]
Patch

Clearing flags on attachment: 384076

Committed r252745: <https://trac.webkit.org/changeset/252745>
Comment 7 WebKit Commit Bot 2019-11-21 12:06:29 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-11-21 12:07:24 PST 
<rdar://problem/57403149>