Experimental support for HDR media query
Created attachment 383987 [details] Patch
Created attachment 383988 [details] Patch
Created attachment 384017 [details] Patch
Comment on attachment 384017 [details] Patch Attachment 384017 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13270400 Number of test failures exceeded the failure limit.
Created attachment 384022 [details] Archive of layout-test-results from ews210 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews210 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Windows EWS failure seems unrelated.
Comment on attachment 384017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384017&action=review > Source/WebCore/css/MediaQueryExpression.cpp:61 > + || mediaFeature == MediaFeatureNames::dynamicRange; Shouldn't this consider hdrMediaCapabilitiesEnabled? > Source/WebCore/platform/cocoa/MediaToolboxSoftLink.cpp:35 > +SOFT_LINK_FRAMEWORK_FOR_SOURCE(WebCore, MediaToolbox) > + > +SOFT_LINK_FUNCTION_MAY_FAIL_FOR_SOURCE(WebCore, MediaToolbox, MTShouldPlayHDRVideo, Boolean, (CFArrayRef displayList), (displayList)) Is there any reason to not put this in PAL?
Comment on attachment 384017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384017&action=review >> Source/WebCore/css/MediaQueryExpression.cpp:61 >> + || mediaFeature == MediaFeatureNames::dynamicRange; > > Shouldn't this consider hdrMediaCapabilitiesEnabled? No, that's taken care of when the value is parsed later. >> Source/WebCore/platform/cocoa/MediaToolboxSoftLink.cpp:35 >> +SOFT_LINK_FUNCTION_MAY_FAIL_FOR_SOURCE(WebCore, MediaToolbox, MTShouldPlayHDRVideo, Boolean, (CFArrayRef displayList), (displayList)) > > Is there any reason to not put this in PAL? Sure, we can move this into PAL.
Created attachment 384091 [details] Patch for landing
Created attachment 384101 [details] Patch for landing
<rdar://problem/56799662>
Comment on attachment 384101 [details] Patch for landing Clearing flags on attachment: 384101 Committed r252762: <https://trac.webkit.org/changeset/252762>
All reviewed patches have been landed. Closing bug.
Reopening to attach new patch.
Created attachment 384725 [details] Follow-up fix
Comment on attachment 384725 [details] Follow-up fix Clearing flags on attachment: 384725 Committed r253062: <https://trac.webkit.org/changeset/253062>