Bug 204422 - Experimental support for HDR media query
Summary: Experimental support for HDR media query
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-20 14:59 PST by Jer Noble
Modified: 2019-12-03 14:35 PST (History)
18 users (show)

See Also:


Attachments
Patch (32.67 KB, patch)
2019-11-20 15:03 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (31.93 KB, patch)
2019-11-20 15:04 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (32.05 KB, patch)
2019-11-20 17:57 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews210 for win-future (13.81 MB, application/zip)
2019-11-20 20:00 PST, EWS Watchlist
no flags Details
Patch for landing (37.05 KB, patch)
2019-11-21 14:30 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (37.29 KB, patch)
2019-11-21 16:28 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Follow-up fix (2.85 KB, patch)
2019-12-03 10:52 PST, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2019-11-20 14:59:25 PST
Experimental support for HDR media query
Comment 1 Jer Noble 2019-11-20 15:03:38 PST
Created attachment 383987 [details]
Patch
Comment 2 Jer Noble 2019-11-20 15:04:36 PST
Created attachment 383988 [details]
Patch
Comment 3 Jer Noble 2019-11-20 17:57:29 PST
Created attachment 384017 [details]
Patch
Comment 4 EWS Watchlist 2019-11-20 20:00:34 PST Comment hidden (obsolete)
Comment 5 EWS Watchlist 2019-11-20 20:00:36 PST Comment hidden (obsolete)
Comment 6 Jer Noble 2019-11-21 09:54:24 PST
Windows EWS failure seems unrelated.
Comment 7 Eric Carlson 2019-11-21 10:32:50 PST
Comment on attachment 384017 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384017&action=review

> Source/WebCore/css/MediaQueryExpression.cpp:61
> +    || mediaFeature == MediaFeatureNames::dynamicRange;

Shouldn't this consider hdrMediaCapabilitiesEnabled?

> Source/WebCore/platform/cocoa/MediaToolboxSoftLink.cpp:35
> +SOFT_LINK_FRAMEWORK_FOR_SOURCE(WebCore, MediaToolbox)
> +
> +SOFT_LINK_FUNCTION_MAY_FAIL_FOR_SOURCE(WebCore, MediaToolbox, MTShouldPlayHDRVideo, Boolean, (CFArrayRef displayList), (displayList))

Is there any reason to not put this in PAL?
Comment 8 Jer Noble 2019-11-21 13:27:02 PST
Comment on attachment 384017 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384017&action=review

>> Source/WebCore/css/MediaQueryExpression.cpp:61
>> +    || mediaFeature == MediaFeatureNames::dynamicRange;
> 
> Shouldn't this consider hdrMediaCapabilitiesEnabled?

No, that's taken care of when the value is parsed later.

>> Source/WebCore/platform/cocoa/MediaToolboxSoftLink.cpp:35
>> +SOFT_LINK_FUNCTION_MAY_FAIL_FOR_SOURCE(WebCore, MediaToolbox, MTShouldPlayHDRVideo, Boolean, (CFArrayRef displayList), (displayList))
> 
> Is there any reason to not put this in PAL?

Sure, we can move this into PAL.
Comment 9 Jer Noble 2019-11-21 14:30:16 PST
Created attachment 384091 [details]
Patch for landing
Comment 10 Jer Noble 2019-11-21 16:28:45 PST
Created attachment 384101 [details]
Patch for landing
Comment 11 Jer Noble 2019-11-21 20:30:33 PST
<rdar://problem/56799662>
Comment 12 WebKit Commit Bot 2019-11-21 21:17:09 PST
Comment on attachment 384101 [details]
Patch for landing

Clearing flags on attachment: 384101

Committed r252762: <https://trac.webkit.org/changeset/252762>
Comment 13 WebKit Commit Bot 2019-11-21 21:17:11 PST
All reviewed patches have been landed.  Closing bug.
Comment 14 Jer Noble 2019-12-03 10:52:26 PST
Reopening to attach new patch.
Comment 15 Jer Noble 2019-12-03 10:52:27 PST
Created attachment 384725 [details]
Follow-up fix
Comment 16 WebKit Commit Bot 2019-12-03 14:35:49 PST
Comment on attachment 384725 [details]
Follow-up fix

Clearing flags on attachment: 384725

Committed r253062: <https://trac.webkit.org/changeset/253062>
Comment 17 WebKit Commit Bot 2019-12-03 14:35:51 PST
All reviewed patches have been landed.  Closing bug.