Bug 204412 – [LFC][IFC] Cache InlinteTextItem width when possible

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

so that subsequent inline layouts don't need to keep remeasuring the text width (I know width-cache helps a bit but still).

[Radar WebKit Bug Importer]

<rdar://problem/57359366>

[alan]

Created attachment 383965 [details]
Patch

[Antti Koivisto]

Comment on attachment 383965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383965&action=review

> Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:93
> +    auto inlineItemWidth = [&] (auto startPosition, auto length) -> Optional<LayoutUnit> {

"[](#spacing-lambda-paren) Do not place spaces between square brackets and parentheses of a lambda function but do place a space before braces."

You r+'d it!

[alan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 383965 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383965&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:93
> > +    auto inlineItemWidth = [&] (auto startPosition, auto length) -> Optional<LayoutUnit> {
> 
> "[](#spacing-lambda-paren) Do not place spaces between square brackets and
> parentheses of a lambda function but do place a space before braces."
> 
> You r+'d it!
must have been one of those 3am reviews.

[alan]

Created attachment 383970 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 383970 [details]
Patch

Clearing flags on attachment: 383970

Committed r252696: <https://trac.webkit.org/changeset/252696>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.