Bug 204405 – Flaky JSC test: stress/stack-overflow-in-yarr-byteCompile.js.dfg-eager

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Aakash Jain]

stress/stack-overflow-in-yarr-byteCompile.js.dfg-eager seems flaky. In https://ews-build.webkit.org/#/builders/1/builds/328, the test failed in jscore-test step. However, in the immediately next retry step (jscore-test-rerun), it passed.

[Aakash Jain]

Another instance of flakiness: https://ews-build.webkit.org/#/builders/1/builds/256

[Aakash Jain]

This test was added recently in https://trac.webkit.org/changeset/252239/webkit

[Mark Lam]

Created attachment 383966 [details]
proposed patch.

[Alexey Proskuryakov]

Comment on attachment 383966 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=383966&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        $vm.allWithStackSize() manipulates the stack in ways that will freak out ASan.
> +        So, add SUPPRESS_ASAN to functionCallWithStackSize() to tell ASan to ignore it.

Was there a separate bug where this was reported?

[Mark Lam]

(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 383966 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383966&action=review
> 
> > Source/JavaScriptCore/ChangeLog:9
> > +        $vm.allWithStackSize() manipulates the stack in ways that will freak out ASan.
> > +        So, add SUPPRESS_ASAN to functionCallWithStackSize() to tell ASan to ignore it.
> 
> Was there a separate bug where this was reported?

Nope.  I just happened to run an ASan build when I was trying to reproduce this issue, and noticed the ASan issue.  Thought I might as well fix it since it can be a source of failures for this test.

[Mark Lam]

Thanks for the review.  Landed in r252694: <http://trac.webkit.org/r252694>.

[Radar WebKit Bug Importer]

<rdar://problem/57365049>

[Radar WebKit Bug Importer]

<rdar://problem/57365050>

[Mark Lam]

<rdar://problem/57365049>

[Michael Saboff]

Comment on attachment 383966 [details]
proposed patch.

lgtm

[Guillaume Emont]

Comment on attachment 383966 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=383966&action=review

> JSTests/stress/stack-overflow-in-yarr-byteCompile.js:2
> +//@ runDefault("--disableOptionsFreezingForTesting")
>  //@ skip if $hostOS != "darwin" or $architecture != "x86-64"

If runDefault() is before the skip, then it is always run. I corrected that in Bug 204522.