[Win][Cygwin][run-api-tests] assert os.pathsep not in value in _append_value_colon_separated AppleWin run-api-tests is failing. https://build.webkit.org/builders/Apple%20Win%2010%20Release%20%28Tests%29/builds/4036 > AssertionError raised: > Traceback (most recent call last): > File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/api_tests/run_api_tests.py", line 59, in main > return run(port, options, args, stderr) > File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/api_tests/run_api_tests.py", line 77, in run > result = manager.run(args, json_output=options.json_output) > File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/api_tests/manager.py", line 171, in run > test_names = self._collect_tests(args) > File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/api_tests/manager.py", line 100, in _collect_tests > env=self._port.environment_for_api_tests()) > File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/port/win.py", line 141, in environment_for_api_tests > env = super(WinPort, self).environment_for_api_tests() > File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/port/base.py", line 266, in environment_for_api_tests > self._append_value_colon_separated(environment, name, build_root_path) > File "/home/buildbot/worker/win10-release-tests/build/Tools/Scripts/webkitpy/port/base.py", line 942, in _append_value_colon_separated > assert os.pathsep not in value > AssertionError
r249500 (Bug 201311) seems the culprit.
Port._build_path contains ':' because webkit-build-directory returns native paths. $ perl webkit-build-directory C:\webkit\gb\WebKitBuild C:/webkit/gb/WebKitBuild/Release
Created attachment 383951 [details] Patch
Comment on attachment 383951 [details] Patch Clearing flags on attachment: 383951 Committed r252714: <https://trac.webkit.org/changeset/252714>
All reviewed patches have been landed. Closing bug.
<rdar://problem/57374957>