Bug 20438 - WebViewWin: WebView::handleContextMenuEvent should use Frame::firstRectForRange
Summary: WebViewWin: WebView::handleContextMenuEvent should use Frame::firstRectForRange
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-18 17:21 PDT by Eric Seidel (no email)
Modified: 2008-08-18 17:21 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2008-08-18 17:21:24 PDT 
The current implementation is a lame copy:

bool WebView::handleContextMenuEvent(WPARAM wParam, LPARAM lParam)

// Calculate the rect of the first line of the selection (cribbed from -[WebCoreFrameBridge firstRectForDOMRange:]).

Of course the fact that firstRectForRange is on Frame is lame to begin with (and I believe only exists for easy export purposes).