Bug 204376 - Assertion failure in HTMLMediaElement::enterFullscreen()
Summary: Assertion failure in HTMLMediaElement::enterFullscreen()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari 13
Hardware: iPhone / iPad iOS 13
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-19 14:15 PST by Peng Liu
Modified: 2019-11-20 14:42 PST (History)
11 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2019-11-19 16:06 PST, Peng Liu 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch (3.33 KB, patch)
2019-11-19 16:57 PST, Peng Liu 		no flags Details | Formatted Diff | Diff
Patch (4.15 KB, patch)
2019-11-19 17:05 PST, Peng Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2019-11-19 14:15:40 PST 
Calling function video.webkitSetPresentationMode('inline') when the video element is in inline mode will fail at "ASSERT(mode != VideoFullscreenModeNone)" in HTMLMediaElement::enterFullscreen().
Comment 1 Radar WebKit Bug Importer 2019-11-19 14:16:20 PST 
<rdar://problem/57336207>
Comment 2 Peng Liu 2019-11-19 15:55:38 PST 
The failure only happens on iPads.
Comment 3 Peng Liu 2019-11-19 16:06:54 PST 
Created attachment 383918 [details]
Patch
Comment 4 Eric Carlson 2019-11-19 16:24:42 PST 
Comment on attachment 383918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383918&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests are required.

This should say why no new tests are required.
Comment 5 Peng Liu 2019-11-19 16:57:02 PST 
Created attachment 383924 [details]
Patch
Comment 6 Peng Liu 2019-11-19 17:05:54 PST 
Created attachment 383927 [details]
Patch
Comment 7 WebKit Commit Bot 2019-11-19 18:37:23 PST 
Comment on attachment 383927 [details]
Patch

Clearing flags on attachment: 383927

Committed r252675: <https://trac.webkit.org/changeset/252675>