Bug 204374 - Bring up WebGL Test Queue
Summary: Bring up WebGL Test Queue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Lewis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-19 14:00 PST by Matt Lewis
Modified: 2019-11-20 13:04 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.98 KB, patch)
2019-11-19 14:08 PST, Matt Lewis 		no flags Details | Formatted Diff | Diff
Patch (5.91 KB, patch)
2019-11-19 16:45 PST, Matt Lewis 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews210 for win-future (14.28 MB, application/zip)
2019-11-19 23:07 PST, EWS Watchlist 		no flags Details
Patch (5.90 KB, patch)
2019-11-20 09:58 PST, Matt Lewis 		jbedard: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2019-11-19 14:00:57 PST 
Making config changes to bring up WebGL testing queue.
Comment 1 Radar WebKit Bug Importer 2019-11-19 14:01:49 PST 
<rdar://problem/57335349>
Comment 2 Matt Lewis 2019-11-19 14:08:25 PST 
Created attachment 383903 [details]
Patch
Comment 3 Aakash Jain 2019-11-19 14:11:01 PST 
Comment on attachment 383903 [details]
Patch

Please update unit-tests, and also verify that 'buildbot checkconfig' passes.
Comment 4 Matt Lewis 2019-11-19 16:45:06 PST 
Created attachment 383920 [details]
Patch
Comment 5 Alexey Proskuryakov 2019-11-19 20:06:53 PST 
Comment on attachment 383920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383920&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:120
> +                      "additionalArguments": ["--no-retry-failures", "--webgl"],

Not a fan of the —webgl switch name. It’s not clear at all from looking at this what it does.
Comment 6 EWS Watchlist 2019-11-19 23:07:17 PST 
Comment on attachment 383920 [details]
Patch

Attachment 383920 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13268580

New failing tests:
fast/dom/domTokenListIterator.html
fast/dom/nodeListIterator.html
fast/dom/NodeList/nodelist-iterable.html
http/tests/security/cross-frame-access-enumeration.html
Comment 7 EWS Watchlist 2019-11-19 23:07:19 PST 
Created attachment 383947 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 8 Jonathan Bedard 2019-11-20 09:15:41 PST 
(In reply to Alexey Proskuryakov from comment #5)
> Comment on attachment 383920 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383920&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:120
> > +                      "additionalArguments": ["--no-retry-failures", "--webgl"],
> 
> Not a fan of the —webgl switch name. It’s not clear at all from looking at
> this what it does.

The help message for --webgl make it clear what the option does, as does the output of run-webkit-tests when you invoke with that argument.

Although, perhaps more importantly, that code hasn't landed yet <https://bugs.webkit.org/show_bug.cgi?id=204327>. Do you have a better idea for what this argument should be?
Comment 9 Matt Lewis 2019-11-20 09:58:36 PST 
Created attachment 383968 [details]
Patch
Comment 10 Jonathan Bedard 2019-11-20 11:35:23 PST 
Comment on attachment 383968 [details]
Patch

Landing this before https://bugs.webkit.org/show_bug.cgi?id=204327 feels wrong though, even if it won't take effect until a restart.
Comment 11 Matt Lewis 2019-11-20 13:04:10 PST 
Committed r252703: <https://trac.webkit.org/changeset/252703>