Bug 204364 - results.webkit.org: Have build.webkit.org report JSC tests
Summary: results.webkit.org: Have build.webkit.org report JSC tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-19 11:11 PST by Jonathan Bedard
Modified: 2019-11-22 06:24 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.08 KB, patch)
2019-11-19 11:14 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (6.44 KB, patch)
2019-11-19 13:09 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-11-19 11:11:56 PST
Buildbot should report JSC results data.
Comment 1 Jonathan Bedard 2019-11-19 11:14:47 PST
Created attachment 383886 [details]
Patch
Comment 2 Aakash Jain 2019-11-19 11:29:01 PST
Comment on attachment 383886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383886&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:347
> +        "--json-output={0}".format(jsonFileName), WithProperties("--%(configuration)s"),

let's keep WithProperties in separate line as it's not related to 'json-output'.

> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:351
> +        "--master-name", "webkit.org",

what does master-name indicate and why is it webkit.org?

> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:352
> +        "--buildbot-master", "build.webkit.org",

build.webkit.org should be a common variable (preferably declared at the beginning of this file). 

Further better, if this could be interpreted from the hostname (socket.gethostname().strip()), e.g.: https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/master.cfg#L75

This would ensure that a uat/testing instance do not impersonate build.webkit.org by mistake.

> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:353
> +        "--report", RESULTS_WEBKIT,

although it's not part of this patch, I think RESULTS_WEBKIT should be renamed to RESULTS_WEBKIT_URL
Comment 3 Aakash Jain 2019-11-19 11:30:50 PST
Comment on attachment 383886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383886&action=review

> Tools/ChangeLog:3
> +        results.webkit.org: Have buildbot report JSC tests

We have multiple buildbot instance. Updated bug title to say build.webkit.org
Comment 4 Jonathan Bedard 2019-11-19 13:08:57 PST
Comment on attachment 383886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383886&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:351
>> +        "--master-name", "webkit.org",
> 
> what does master-name indicate and why is it webkit.org?

That's a key from run-webkit-tests that involved reporting to the old results database. Shouldn't have been included.
Comment 5 Jonathan Bedard 2019-11-19 13:09:04 PST
Created attachment 383897 [details]
Patch
Comment 6 WebKit Commit Bot 2019-11-19 14:06:50 PST
Comment on attachment 383897 [details]
Patch

Clearing flags on attachment: 383897

Committed r252648: <https://trac.webkit.org/changeset/252648>
Comment 7 WebKit Commit Bot 2019-11-19 14:06:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-11-19 14:07:19 PST
<rdar://problem/57335653>