Bug 204358 - [iOS] Fix sysctl-read sandbox violation
Summary: [iOS] Fix sysctl-read sandbox violation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
: 204359 204360 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-11-19 10:33 PST by Per Arne Vollan
Modified: 2020-01-13 12:54 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.24 KB, patch)
2019-11-19 10:35 PST, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2019-11-19 12:08 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-11-19 10:33:24 PST 
The WebContent sandbox should allow sysctl-read of "kern.hostname".
Comment 1 Per Arne Vollan 2019-11-19 10:33:44 PST 
rdar://problem/57298313
Comment 2 Per Arne Vollan 2019-11-19 10:35:06 PST 
Created attachment 383880 [details]
Patch
Comment 3 Brent Fulgham 2019-11-19 11:28:44 PST 
Comment on attachment 383880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383880&action=review

r=me

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:852
> +        "kern.hostname"

I propose we also add the other two items we noticed in this same patch?

kern.osrelease
kern.version
Comment 4 Per Arne Vollan 2019-11-19 11:37:33 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 383880 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=383880&action=review
> 
> r=me
> 
> > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:852
> > +        "kern.hostname"
> 
> I propose we also add the other two items we noticed in this same patch?
> 
> kern.osrelease
> kern.version

Will do!

Thanks for reviewing :)
Comment 5 Per Arne Vollan 2019-11-19 12:08:33 PST 
Created attachment 383893 [details]
Patch
Comment 6 Brent Fulgham 2019-11-19 12:12:33 PST 
Comment on attachment 383893 [details]
Patch

Looks great! r=me
Comment 7 WebKit Commit Bot 2019-11-19 13:00:28 PST 
Comment on attachment 383893 [details]
Patch

Clearing flags on attachment: 383893

Committed r252643: <https://trac.webkit.org/changeset/252643>
Comment 8 Aakash Jain 2019-11-19 17:20:02 PST 
> Committed r252643: <https://trac.webkit.org/changeset/252643>
Did you want to close the bug as well?
Comment 9 Per Arne Vollan 2019-11-20 11:37:54 PST 
(In reply to Aakash Jain from comment #8)
> > Committed r252643: <https://trac.webkit.org/changeset/252643>
> Did you want to close the bug as well?

Yes, thanks!
Comment 10 Brent Fulgham 2020-01-13 12:53:18 PST 
*** Bug 204359 has been marked as a duplicate of this bug. ***
Comment 11 Brent Fulgham 2020-01-13 12:54:14 PST 
*** Bug 204360 has been marked as a duplicate of this bug. ***