RESOLVED FIXED 204354
[LFC][IFC] Assign inlineCapacity to various inline run vectors. 
https://bugs.webkit.org/show_bug.cgi?id=204354
Summary [LFC][IFC] Assign inlineCapacity to various inline run vectors.
alan
Reported 2019-11-19 08:08:27 PST
ssia
Attachments
Patch (4.45 KB, patch)
2019-11-19 08:14 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (8.71 KB, patch)
2019-11-19 08:58 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (10.27 KB, patch)
2019-11-19 10:20 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-11-19 08:08:48 PST
<rdar://problem/57322347>
alan
Comment 2 2019-11-19 08:14:03 PST
Created attachment 383869 [details] Patch
alan
Comment 3 2019-11-19 08:58:11 PST
Created attachment 383874 [details] Patch
Antti Koivisto
Comment 4 2019-11-19 09:16:11 PST
Comment on attachment 383874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383874&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingState.h:43 > +using InlineItems = Vector<std::unique_ptr<InlineItem>, 30>; > +using InlineRuns = Vector<std::unique_ptr<Display::Run>, 10>; > +using LineBoxes = Vector<std::unique_ptr<LineBox>, 5>; Maybe some of these can be Vector<Foo,..> instead of Vector<std::unique_ptr<Foo>,...> too? Would probably be faster if we can avoid heap allocations. > Source/WebCore/layout/inlineformatting/InlineLine.h:72 > + Run& operator=(Run&& other); I don't see implementation of this. I suppose it is not needed if things compile/link. If you need it, you can default it too.
Antti Koivisto
Comment 5 2019-11-19 09:17:50 PST
Also for any temporary vectors, it likely won't hurt to have more inline capacity than usually needed. No need to tune them to common case.
alan
Comment 6 2019-11-19 10:20:31 PST
Created attachment 383879 [details] Patch
WebKit Commit Bot
Comment 7 2019-11-19 10:58:11 PST
Comment on attachment 383879 [details] Patch Clearing flags on attachment: 383879 Committed r252638: <https://trac.webkit.org/changeset/252638>
WebKit Commit Bot
Comment 8 2019-11-19 10:58:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.