Created attachment 383869 [details]
Created attachment 383874 [details]
Comment on attachment 383874 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=383874&action=review
> +using InlineItems = Vector<std::unique_ptr<InlineItem>, 30>;
> +using InlineRuns = Vector<std::unique_ptr<Display::Run>, 10>;
> +using LineBoxes = Vector<std::unique_ptr<LineBox>, 5>;
Maybe some of these can be Vector<Foo,..> instead of Vector<std::unique_ptr<Foo>,...> too? Would probably be faster if we can avoid heap allocations.
> + Run& operator=(Run&& other);
I don't see implementation of this. I suppose it is not needed if things compile/link.
If you need it, you can default it too.
Also for any temporary vectors, it likely won't hurt to have more inline capacity than usually needed. No need to tune them to common case.
Created attachment 383879 [details]
Comment on attachment 383879 [details]
Clearing flags on attachment: 383879
Committed r252638: <https://trac.webkit.org/changeset/252638>
All reviewed patches have been landed. Closing bug.