Bug 204350 - [JSC] DisallowVMReentry and DeferGC should use WTF::ThreadSpecific instead of using WTF::threadSpecificKeyCreate directly
Summary: [JSC] DisallowVMReentry and DeferGC should use WTF::ThreadSpecific instead of...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-19 04:10 PST by Fujii Hironori
Modified: 2019-11-19 18:11 PST (History)
10 users (show)

See Also:

Attachments
Patch (5.12 KB, patch)
2019-11-19 04:13 PST, Fujii Hironori 		ysuzuki: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-11-19 04:10:26 PST 
WTF provides two thread specific storages, ThreadSpecific and
threadSpecificKeyCreate. Only DisallowVMReentry and DeferGC are using
threadSpecificKeyCreate. WTF::ThreadSpecific should be used because it
is a useful wrapper.
Comment 1 Fujii Hironori 2019-11-19 04:13:58 PST 
Created attachment 383860 [details]
Patch
Comment 2 Yusuke Suzuki 2019-11-19 13:58:57 PST 
Comment on attachment 383860 [details]
Patch

r=me
Comment 3 Fujii Hironori 2019-11-19 18:10:05 PST 
Committed r252671: <https://trac.webkit.org/changeset/252671>
Comment 4 Radar WebKit Bug Importer 2019-11-19 18:11:18 PST 
<rdar://problem/57344999>