Bug 204348 - REGRESSION (r252161): box-shadow with inset and rounded borders is clipped
Summary: REGRESSION (r252161): box-shadow with inset and rounded borders is clipped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-19 03:33 PST by Antoine Quint
Modified: 2020-05-06 14:36 PDT (History)
10 users (show)

See Also:

Attachments
Reduction (298 bytes, text/html)
2019-11-19 03:51 PST, Antoine Quint 		no flags Details
Patch (4.82 KB, patch)
2019-11-19 16:05 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-11-19 03:33:10 PST 
This simple test is now clipped after r252161:

<style>

    div {
        border-top-left-radius: 50%;
        border-top-right-radius: 50%;
        border-bottom-left-radius: 50%;
        border-bottom-right-radius: 50%;
        box-shadow: black 0px 0px 0px 2px inset;
        height: 40px;
        width: 40px;
    }
    
</style>
<div></div>
Comment 1 Antoine Quint 2019-11-19 03:35:42 PST 
<rdar://57226117>
Comment 2 Antoine Quint 2019-11-19 03:51:00 PST 
Created attachment 383858 [details]
Reduction
Comment 3 Simon Fraser (smfr) 2019-11-19 16:05:36 PST 
Created attachment 383917 [details]
Patch
Comment 4 WebKit Commit Bot 2019-11-20 09:12:15 PST 
Comment on attachment 383917 [details]
Patch

Clearing flags on attachment: 383917

Committed r252689: <https://trac.webkit.org/changeset/252689>
Comment 5 WebKit Commit Bot 2019-11-20 09:12:17 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Antoine Quint 2020-05-06 14:36:32 PDT 
This improved a regression but didn't quite fix it perfectly, see bug 211530.