Bug 204335 - Rename AbstractEventLoop to EventLoop and move to its own cpp file
Summary: Rename AbstractEventLoop to EventLoop and move to its own cpp file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on: 204263
Blocks: 203667 204042
  Show dependency treegraph
 
Reported: 2019-11-18 17:47 PST by Ryosuke Niwa
Modified: 2019-11-19 14:00 PST (History)
20 users (show)

See Also:


Attachments
Cleanup (20.83 KB, patch)
2019-11-18 17:57 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Cleanup (37.30 KB, patch)
2019-11-18 17:59 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Cleanup (37.30 KB, patch)
2019-11-18 18:03 PST, Ryosuke Niwa
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-11-18 17:47:33 PST
Now that the much of event loop implementation moved to AbstractEventLoop in r252607, move to its own file.
Comment 1 Ryosuke Niwa 2019-11-18 17:57:15 PST
Created attachment 383823 [details]
Cleanup
Comment 2 Ryosuke Niwa 2019-11-18 17:59:54 PST
Created attachment 383825 [details]
Cleanup
Comment 3 Ryosuke Niwa 2019-11-18 18:03:30 PST
Created attachment 383828 [details]
Cleanup
Comment 4 Ryosuke Niwa 2019-11-18 18:05:05 PST
Comment on attachment 383828 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=383828&action=review

> Source/WebCore/dom/EventLoop.h:62
> +class AbstractEventLoop : public RefCounted<AbstractEventLoop>, public CanMakeWeakPtr<AbstractEventLoop> {

Note that this is the old file content for svn mv. See below for the actual diff.
Comment 5 Ryosuke Niwa 2019-11-18 18:06:37 PST
Comment on attachment 383828 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=383828&action=review

>> Source/WebCore/dom/EventLoop.h:62
>> +class EventLoop : public RefCounted<EventLoop>, public CanMakeWeakPtr<EventLoop> {
> 
> Note that this is the old file content for svn mv. See below for the actual diff.

Huh, I guess review tool can't tell to which file the comment is added. I meant to add this to the file above which shows the original content of the file.
Comment 6 Ryosuke Niwa 2019-11-19 00:32:27 PST
Comment on attachment 383828 [details]
Cleanup

Thanks for review!
Comment 7 Ryosuke Niwa 2019-11-19 00:33:50 PST
Comment on attachment 383828 [details]
Cleanup

Hold on, this isn’t go gonna work in CQ. Will land manually tomorrow.
Comment 8 Antti Koivisto 2019-11-19 00:34:36 PST
(In reply to Ryosuke Niwa from comment #4)
> Note that this is the old file content for svn mv. See below for the actual
> diff.

How did you generate the diff? Git usually seems to produce nicer diffs for move/renames (see https://bugs.webkit.org/attachment.cgi?id=383806&action=review for example).
Comment 9 Ryosuke Niwa 2019-11-19 00:36:17 PST
(In reply to Antti Koivisto from comment #8)
> (In reply to Ryosuke Niwa from comment #4)
> > Note that this is the old file content for svn mv. See below for the actual
> > diff.
> 
> How did you generate the diff? Git usually seems to produce nicer diffs for
> move/renames (see
> https://bugs.webkit.org/attachment.cgi?id=383806&action=review for example).

I did svn mv then modified the file. This used to work too but someone broke it some point and nobody fixed it.
Comment 10 Ryosuke Niwa 2019-11-19 13:57:54 PST
Committed r252646: <https://trac.webkit.org/changeset/252646>
Comment 11 Radar WebKit Bug Importer 2019-11-19 13:58:20 PST
<rdar://problem/57335190>