Now that the much of event loop implementation moved to AbstractEventLoop in r252607, move to its own file.
Created attachment 383823 [details] Cleanup
Created attachment 383825 [details] Cleanup
Created attachment 383828 [details] Cleanup
Comment on attachment 383828 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=383828&action=review > Source/WebCore/dom/EventLoop.h:62 > +class AbstractEventLoop : public RefCounted<AbstractEventLoop>, public CanMakeWeakPtr<AbstractEventLoop> { Note that this is the old file content for svn mv. See below for the actual diff.
Comment on attachment 383828 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=383828&action=review >> Source/WebCore/dom/EventLoop.h:62 >> +class EventLoop : public RefCounted<EventLoop>, public CanMakeWeakPtr<EventLoop> { > > Note that this is the old file content for svn mv. See below for the actual diff. Huh, I guess review tool can't tell to which file the comment is added. I meant to add this to the file above which shows the original content of the file.
Comment on attachment 383828 [details] Cleanup Thanks for review!
Comment on attachment 383828 [details] Cleanup Hold on, this isn’t go gonna work in CQ. Will land manually tomorrow.
(In reply to Ryosuke Niwa from comment #4) > Note that this is the old file content for svn mv. See below for the actual > diff. How did you generate the diff? Git usually seems to produce nicer diffs for move/renames (see https://bugs.webkit.org/attachment.cgi?id=383806&action=review for example).
(In reply to Antti Koivisto from comment #8) > (In reply to Ryosuke Niwa from comment #4) > > Note that this is the old file content for svn mv. See below for the actual > > diff. > > How did you generate the diff? Git usually seems to produce nicer diffs for > move/renames (see > https://bugs.webkit.org/attachment.cgi?id=383806&action=review for example). I did svn mv then modified the file. This used to work too but someone broke it some point and nobody fixed it.
Committed r252646: <https://trac.webkit.org/changeset/252646>
<rdar://problem/57335190>