Bug 204335 – Rename AbstractEventLoop to EventLoop and move to its own cpp file

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

Now that the much of event loop implementation moved to AbstractEventLoop in r252607, move to its own file.

[Ryosuke Niwa]

Created attachment 383823 [details]
Cleanup

[Ryosuke Niwa]

Created attachment 383825 [details]
Cleanup

[Ryosuke Niwa]

Created attachment 383828 [details]
Cleanup

[Ryosuke Niwa]

Comment on attachment 383828 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=383828&action=review

> Source/WebCore/dom/EventLoop.h:62
> +class AbstractEventLoop : public RefCounted<AbstractEventLoop>, public CanMakeWeakPtr<AbstractEventLoop> {

Note that this is the old file content for svn mv. See below for the actual diff.

[Ryosuke Niwa]

Comment on attachment 383828 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=383828&action=review

>> Source/WebCore/dom/EventLoop.h:62
>> +class EventLoop : public RefCounted<EventLoop>, public CanMakeWeakPtr<EventLoop> {
> 
> Note that this is the old file content for svn mv. See below for the actual diff.

Huh, I guess review tool can't tell to which file the comment is added. I meant to add this to the file above which shows the original content of the file.

[Ryosuke Niwa]

Comment on attachment 383828 [details]
Cleanup

Thanks for review!

[Ryosuke Niwa]

Comment on attachment 383828 [details]
Cleanup

Hold on, this isn’t go gonna work in CQ. Will land manually tomorrow.

[Antti Koivisto]

(In reply to Ryosuke Niwa from comment #4)
> Note that this is the old file content for svn mv. See below for the actual
> diff.

How did you generate the diff? Git usually seems to produce nicer diffs for move/renames (see https://bugs.webkit.org/attachment.cgi?id=383806&action=review for example).

[Ryosuke Niwa]

(In reply to Antti Koivisto from comment #8)
> (In reply to Ryosuke Niwa from comment #4)
> > Note that this is the old file content for svn mv. See below for the actual
> > diff.
> 
> How did you generate the diff? Git usually seems to produce nicer diffs for
> move/renames (see
> https://bugs.webkit.org/attachment.cgi?id=383806&action=review for example).

I did svn mv then modified the file. This used to work too but someone broke it some point and nobody fixed it.

[Ryosuke Niwa]

Committed r252646: <https://trac.webkit.org/changeset/252646>

[Radar WebKit Bug Importer]

<rdar://problem/57335190>