RESOLVED FIXED204333
Always enable Optional<OptionsStorage::Size> parse(const char* string) for OS(DARWIN). 
https://bugs.webkit.org/show_bug.cgi?id=204333
Summary Always enable Optional<OptionsStorage::Size> parse(const char* string) for OS...
Mark Lam
Reported 2019-11-18 17:18:37 PST
<rdar://problem/57303785>
Attachments
proposed patch. (1.82 KB, patch)
2019-11-18 17:24 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (1.55 KB, patch)
2019-11-18 18:30 PST, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-11-18 17:24:40 PST
Created attachment 383815 [details] proposed patch. Let's try this on the EWS.
Mark Lam
Comment 2 2019-11-18 17:36:38 PST
Sadly, it looks the static_assert trick does not solve this problem. I'll investigate alternate solutions.
Mark Lam
Comment 3 2019-11-18 18:30:54 PST
Created attachment 383832 [details] proposed patch.
Yusuke Suzuki
Comment 4 2019-11-18 18:39:44 PST
Comment on attachment 383832 [details] proposed patch. r=me. BTW, how about replacing size_t with uint64_t (or uint32_t) completely?
Mark Lam
Comment 5 2019-11-18 18:43:57 PST
Thanks for the reviewer. (In reply to Yusuke Suzuki from comment #4) > Comment on attachment 383832 [details] > proposed patch. > > r=me. BTW, how about replacing size_t with uint64_t (or uint32_t) completely? I kinda like it as it is because it's clearer this way that the parse() functions map to each option storage type.
Mark Lam
Comment 6 2019-11-18 18:49:17 PST
Landed in r252618: <http://trac.webkit.org/r252618>.
Note You need to log in before you can comment on or make changes to this bug.