Bug 20433 - Kill getPixmap and use nativeImageForCurrentFrame
Summary: Kill getPixmap and use nativeImageForCurrentFrame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-18 14:28 PDT by Holger Freyther
Modified: 2008-09-16 21:38 PDT (History)
1 user (show)

See Also:


Attachments
Use the common method (7.06 KB, patch)
2008-08-18 14:29 PDT, Holger Freyther
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2008-08-18 14:28:26 PDT
Replace Qt specific code with the generic nativeImageForCurrentFrame. There is simply no need for a custom Qt method.
Comment 1 Holger Freyther 2008-08-18 14:29:42 PDT
Created attachment 22861 [details]
Use the common method
Comment 2 Eric Seidel (no email) 2008-08-22 01:46:05 PDT
Comment on attachment 22861 [details]
Use the common method

Wooohoo!

I plan to add a
nativeImageForFirstFrame()

method eventually, which would closer match the behavior of what you're replacing.  However I think the currentFrame should be fine in these uses.
Comment 3 Alp Toker 2008-09-16 21:38:48 PDT
Prepared this patch for landing and found it was already applied :-(

Closing bug.